Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fr version #195

Merged
merged 2 commits into from
Jul 8, 2019
Merged

fr version #195

merged 2 commits into from
Jul 8, 2019

Conversation

brandelune
Copy link
Contributor

Let me know if there are things I missed on the technical side.

@r12a
Copy link
Contributor

r12a commented Jul 5, 2019

Hello @brandelune. Thanks for posting this and the other PR. Here are some things to fix here, and check in the other document, if you wouldn't mind. Please also run the files through the html validator. (Ignore the stuff about the Javascript type attribute.)

  1. Change the language tag in the html tag to fr.
  2. Remove the superfluous code: <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  3. Add your name at the place indicated in the javascript variable assignements.
  4. Change the lang id a little further down, where it says 'TRANSLATORS..'

The rest of the page looks good.

Once you update the files in this PR, i'll check the other document.

thanks!

@brandelune
Copy link
Contributor Author

Ok, I'll do.

@brandelune
Copy link
Contributor Author

Also, the https://validator.w3.org/nu/ validator gave me weird results on the FR file as well as on the original (stray end tag on line 134).

@brandelune
Copy link
Contributor Author

I just committed the 2 modifications.

@r12a r12a merged commit 07e189d into w3c:gh-pages Jul 8, 2019
@r12a
Copy link
Contributor

r12a commented Jul 8, 2019

Thanks @brandelune ! Both translations are now live, linked, and announced. Merci bien.

@brandelune
Copy link
Contributor Author

Yeah :) On to the next :) Thank you @r12a :)

@brandelune brandelune deleted the patch-1 branch July 8, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants