Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Addison's email #398

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Update Addison's email #398

merged 2 commits into from
Jun 22, 2022

Conversation

xfq
Copy link
Member

@xfq xfq commented Jun 15, 2022

Fix #396.

@xfq xfq requested review from aphillips and r12a June 15, 2022 07:59
Copy link
Contributor

@r12a r12a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed the link text in the last 3 files. Otherwise, seems ok.

@netlify
Copy link

netlify bot commented Jun 15, 2022

Deploy Preview for i18n-drafts ready!

Name Link
🔨 Latest commit 803cfdf
🔍 Latest deploy log https://app.netlify.com/sites/i18n-drafts/deploys/62a9daebf0fff20009945489
😎 Deploy Preview https://deploy-preview-398--i18n-drafts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@xfq
Copy link
Member Author

xfq commented Jun 15, 2022

I'm trying adding Netlify to this repo.

The Deploy Preview link above returns 404, because I changed multiple files in this PR, and Netlify didn't know which file to preview (and we don't have an index.html at the top level of the repo). If you want to preview an individual HTML file, you can add the path of it after the Deploy Preview link, for example:

https://deploy-preview-398--i18n-drafts.netlify.app/getting-started/languagedev_participation.html#contacts is not 404.

If only one file is modified in a PR, the Deploy Preview link won't be a 404 page, like this one.

@xfq xfq merged commit 7f35e17 into gh-pages Jun 22, 2022
@xfq xfq deleted the xfq/addison-email branch June 22, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Addison's email address
2 participants