Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ijam and tashkil to glossary (I18N-ACTION-1200) and fix addison's info #15

Merged
merged 6 commits into from
Sep 15, 2022

Conversation

aphillips
Copy link
Collaborator

@aphillips aphillips commented Sep 13, 2022

@aphillips
Copy link
Collaborator Author

This didn't trigger the previewer tool and I don't seem to have write access to this repo. @xfq can you check it?

@aphillips aphillips changed the title Fix addison's info Add ijam and tashkil to glossary (I18N-ACTION-1200) and fix addison's info Sep 13, 2022
@xfq
Copy link
Member

xfq commented Sep 14, 2022

Should be fixed now. You can push a commit to trigger the previewer tool, @aphillips.

@aphillips aphillips requested review from r12a and xfq September 14, 2022 15:42
Our commonly used styles (like `uname`) were not present and we commented out the local.css file and didn't copy it in. I took the embedded styles and moved them to a copy of the specdev local.css file.

This does have presentational side effects. @r12a you should have a look at this. I could also just start building up a minimal `local.css` with just the local styles needed. Thoughts?
@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for i18n-glossary ready!

Name Link
🔨 Latest commit b7db1a5
🔍 Latest deploy log https://app.netlify.com/sites/i18n-glossary/deploys/63235ccab5f19e0009b1c799
😎 Deploy Preview https://deploy-preview-15--i18n-glossary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

index.html Outdated
@@ -248,6 +250,14 @@ <h2>Glossary</h2>

<div class="letter_anchor" id="i">I</div>

<p><dfn id="def_ijam" class="lint-ignore export">Ijam</dfn>. An ijam is an Arabic script diacritical mark considered to be part of a basic letter form. &#x681; [<span class="uname" translate="no">U+0681 ARABIC LETTER HAH WITH HAMZA ABOVE</span>] is an example of a letter with an ijam. Unicode encodes letter+ijam combinations as separate, atomic characters, which are never given decompositions in the standard. Ijam generally take the form of one-, two-, three- or four-dot markings above or below the basic letter skeleton, although other diacritic forms occur in extensions of the Arabic script in Central and South Asia and in Africa.</p>

<aside class="note">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The glossary keeps definitions short on purpose, and limits the descriptions to one paragraph. For this kind of additional information (some of which actually begins to wander off track) we should point out to somewhere else (probably your original source for this text, which is https://r12a.github.io/scripts/arabic/arb.html#ijam_tashkil).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition really must have a link to the tashkil entry, and vice versa.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example of hah+hamza needs clarification to indicate that it represents a consonant in Pashto. I will add that to the orthography description too.

index.html Outdated
<p><dfn id="def_ijam" class="lint-ignore export">Ijam</dfn>. An ijam is an Arabic script diacritical mark considered to be part of a basic letter form. &#x681; [<span class="uname" translate="no">U+0681 ARABIC LETTER HAH WITH HAMZA ABOVE</span>] is an example of a letter with an ijam. Unicode encodes letter+ijam combinations as separate, atomic characters, which are never given decompositions in the standard. Ijam generally take the form of one-, two-, three- or four-dot markings above or below the basic letter skeleton, although other diacritic forms occur in extensions of the Arabic script in Central and South Asia and in Africa.</p>

<aside class="note">
<p>This distinction between using a character with <a>ijam</a> instead of combining a letter with a <a>tashkil</a> becomes important when choosing which Unicode characters to use because (as can be seen in the examples above) the visual forms can be identical. Using the wrong character can change the meaning of the text, affecting the results of text search, font rendering, text to speech, etc.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like us to remove this paragraph and the following one.
Same applies to the tashkil section.

@@ -39,7 +39,8 @@

};
</script>
<!--link rel="stylesheet" href="local.css" /-->
<link rel="stylesheet" href="local.css">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally commented out the local.css file. We need to check what differences are made by including it. If ok to include, we should reference the same file as other pages, so that we don't need to update in various locations. If it needs tailoring, we should probably consider our options.

index.html Outdated

<p>There are, however, some very common combinations of diacritic and base that can be represented using precomposed characters or decomposed sequences that are canonically equivalent. For those the standard encourages the use of the precomposed form, but the fact that the forms are canonically equivalent removes concerns about changes in meaning.</p>
</aside>
<p><dfn id="def_tashkil" class="lint-ignore export">Tashkil</dfn>. A tashkil (تَشْكِيل) is an Arabic script mark that indicates vocalization of text, as well as other types of phonetic guides to correct pronunciation. &#x62d;&#x654; [<span class="uname" translate="no">U+062D ARABIC LETTER HAH + U+0654 ARABIC HAMZA ABOVE</span>] is an example of a letter plus tashkil combination. Tashkil are separately encoded as combining marks. These include several subtypes: <em>harakat</em> (short vowel marks), <em>tanwin</em> (postnasalized or long vowel marks), <em>shaddah</em> (consonant gemination mark), and <em>sukun</em> (to mark lack of a following vowel). A basic Arabic letter plus any of these types of marks is never encoded as a separate, precomposed character, but must always be represented as a sequence of letter plus combining mark. Additional marks invented to indicate non-Arabic vowels, used in extensions of the Arabic script for languages other than Arabic, are also encoded as separate combining marks. See also: <a>ijam</a>. For more information see <a href="https://r12a.github.io/scripts/arabic/arb.html#ijam_tashkil">this article</a>.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the arabic text needs markup and a lang tag

we should probably also add the arabic spelling for ijam if we have it here

Added correct codepoint markup.

Fixed internal termref styling.

Adjusted wording of the external link.

Converted Arabic term to NCRs.

@r12a Note that I tagged the tashkil example with language tag `ps` instead of `ar`. Is that appropriate?
@aphillips
Copy link
Collaborator Author

Merging this per our discussion in 2022-09-15 teleconference. @r12a will make additional edits and also address the stylesheet issues. Note that this means that the ED is using the gigantor local.css file and we should probably wait to push this to TR until we resolve some of the CSS issues.

@aphillips aphillips merged commit cb7b8fc into w3c:gh-pages Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants