Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for publication (links, validator, echidna manifest) #34

Merged
merged 15 commits into from
Apr 21, 2023

Conversation

aphillips
Copy link
Collaborator

@aphillips aphillips commented Mar 28, 2023

Preparing to update TR the link checker complained about some permanent redirects on http => https. In addition to the items it pointed to, I corrected the other links to the unicode.org website.


Preview | Diff

@aphillips aphillips requested review from xfq and r12a March 28, 2023 16:37
@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for i18n-glossary ready!

Name Link
🔨 Latest commit b1b05fb
🔍 Latest deploy log https://app.netlify.com/sites/i18n-glossary/deploys/64425ab821638f000959de78
😎 Deploy Preview https://deploy-preview-34--i18n-glossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

One link to `util.unicode.org` failed to escape the `[:` and `:]`
We added a graphic. The tool also wants the CSS in i18n-drafts, so added
that too.
@aphillips aphillips changed the title Replace all http with https Prepare for publication (links, validator, echidna manifest) Mar 28, 2023
echidna Outdated Show resolved Hide resolved
@aphillips aphillips requested a review from r12a March 29, 2023 18:20
index.html Outdated Show resolved Hide resolved
local.css Outdated
font-size: 85%;
letter-spacing:0.03em;
}
font-variant: all-small-caps;
Copy link
Contributor

@r12a r12a Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasons i didn't use font-variant:

  1. i'm not clear what that improves
  2. there is no mix of upper and lower case here
  3. i don't want the browser to synthesise glyphs
  4. it looks too small
  5. SC font glyphs are not matched to caseless characters around them

In addition, the letter-spacing value was chosen with care, and following guidance from R Bringshurst, to make the uppercase letters more readable and less compact, so please keep that, too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the one change i would suggest is to remove the uppercase setting. It was only ever there as bulletproofing, but actually it would be better to be able to see when someone has typed a Unicode name or code point value in lowercase, because then it's more likely to be fixed before someone tries to copy paste it somewhere.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @r12a

I had kept the uppercasing because I assumed it was there for bulletproofing. Should I remove it and keep the remainder? Perhaps suggest what the complete style should be.

Side note that you might have missed: I removed the :lang from the .codepoint bdi because I couldn't see why we wouldn't style non-English-language glyphs larger. Users could still style specific language glyphs to use a font-family or resize to their needs by using their own :lang. Thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What i'm suggesting is to make it just:

.uname {
    font-size: 85%;
    letter-spacing:0.03em;
    }

I'm flexible about the font-size value. Could be 80%.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrt :lang. Yes, i saw that, and that's why i mentioned that authors may need to style the bdi (not the uname) differently depending on the language. I can't think of any reason to use :lang styling on the uname.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you probably know, .unames are coloured in my docs, but they are the same colour as links. I can't decide whether that's ok, because in my docs clicking on them opens up popup windows. But for W3C docs i suppose we need to choose a colour that doesn't make it look like a link - or anything else. (I think .kw produces a blue colour.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Maybe avoid blue in favor of a non-link-like color. Above I used a random blue. Who could provide guidance here? fantasai?

Copy link
Member

@xfq xfq Apr 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, UI Events uses a green colour for code points: https://w3c.github.io/uievents-code/#style-conventions

We could also consider using orange, which is similar to our theme colour at https://www.w3.org/International/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xfq. Green might be good, although I wouldn't use background coloring. Orange has the problem of being low contrast. Maybe the solution is to put it into the tr-design PR and just ask for color guidance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, i'd favour a colour that (providing it has enough contrast) doesn't jump out at you, like the blue above and the uievents styling. I'd prefer the actual character to be the main thing that jumps out, with the number and name as backup, rather than the main event.

@@ -40,6 +40,8 @@
};
</script>
<link rel="stylesheet" data-import href="https://w3c.github.io/i18n-drafts/style/respec_2022.css">
<link rel="stylesheet" data-import href="local.css">
<link rel="stylesheet" data-import href="local.css">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is a duplicate

@@ -275,21 +279,21 @@ <h2>Glossary</h2>

<p><dfn class="lint-ignore export">Grapheme</dfn>. A character or a sequence of characters in a visual representation of some text that a typical user would perceive as being a single unit (<q>character</q>). Graphemes are important for a number of text operations such as sorting or text selection, so it is necessary to be able to compute the boundaries between each user-perceived character. For more information about graphemes and grapheme clusters, with examples, see <a href="https://www.w3.org/International/articles/definitions-characters/index#characters">Character encodings: Essential concepts</a>.</p>

<p><dfn class="lint-ignore export">Grapheme cluster</dfn>. A grapheme cluster is defined by the Unicode Standard as the default mechanism for computing an approximation to [=graphemes=] (see <cite>Unicode Standard Annex #29: Text Segmentation</cite> [[UAX29]]). Two types of default grapheme cluster are defined. Unless otherwise noted, <q>grapheme cluster</q> in this document refers to an <q>extended default grapheme cluster</q>. (A discussion of grapheme clusters is also given in Section 2 of the <cite>Unicode Standard</cite>, [[Unicode]]. Cf. near the end of <a href="http://www.unicode.org/versions/latest/ch02.pdf">Section 2.11</a> in version 14.0 of The Unicode Standard.) Because different natural languages have different needs, grapheme clusters can also sometimes require tailoring. For example, a Slovak user might wish to treat the default pair of grapheme clusters "ch" as a single grapheme cluster. Note that the interaction between the language of string content and the end-user's preferences might be complex.</p>
<p><dfn class="lint-ignore export">Grapheme cluster</dfn>. A grapheme cluster is defined by the Unicode Standard as the default mechanism for computing an approximation to [=graphemes=] (see <cite>Unicode Standard Annex #29: Text Segmentation</cite> [[UAX29]]). Two types of default grapheme cluster are defined. Unless otherwise noted, <q>grapheme cluster</q> in this document refers to an <q>extended default grapheme cluster</q>. (A discussion of grapheme clusters is also given in Section 2 of the <cite>Unicode Standard</cite>, [[Unicode]]. Cf. near the end of <a href="https://www.unicode.org/versions/latest/ch02.pdf">Section 2.11</a> in version 14.0 of The Unicode Standard.) Because different natural languages have different needs, grapheme clusters can also sometimes require tailoring. For example, a Slovak user might wish to treat the default pair of grapheme clusters "ch" as a single grapheme cluster. Note that the interaction between the language of string content and the end-user's preferences might be complex.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this changed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it changed the Unicode website URL from http to https.

local.css Outdated
font-size: 85%;
letter-spacing:0.03em;
}
font-variant: all-small-caps;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, i'd favour a colour that (providing it has enough contrast) doesn't jump out at you, like the blue above and the uievents styling. I'd prefer the actual character to be the main thing that jumps out, with the number and name as backup, rather than the main event.

- also make markup consistent in two places
- use Arial + monospaced
- use line-height 1em
@aphillips
Copy link
Collaborator Author

Merging per call of 2023-04-20.

@aphillips aphillips merged commit aa917e2 into w3c:gh-pages Apr 21, 2023
xfq added a commit to w3c/i18n-activity that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants