Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Recommendation #77

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Proposed Recommendation #77

merged 5 commits into from
Feb 29, 2024

Conversation

palemieux
Copy link
Contributor

@palemieux palemieux commented Jan 11, 2024

  • Add acknowledgements section
  • Improve note in Objective section

Preview | Diff

Improve note in Objective section
Bump to PR
@palemieux palemieux self-assigned this Jan 11, 2024
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, modulo the strange review date.

spec/imsc-hrm.html Show resolved Hide resolved
@nigelmegitt
Copy link
Contributor

Should we still include the CR exit criteria in the PR, or should those be removed (from the SOTD section)?

@himorin
Copy link
Contributor

himorin commented Jan 22, 2024

Should we still include the CR exit criteria in the PR, or should those be removed (from the SOTD section)?

In short, yes.

By testing locally, I've got respec error message for specStatus=PR without crEnd. Also a sentence like,

Note that substantive technical comments were expected during the Candidate Recommendation review period that ended XX XXX 202X.

seems to be mandatory for PR publication.

@nigelmegitt
Copy link
Contributor

Thanks for that @himorin, then we should keep it. Looking at this text in the SOTD:

The W3C Membership and other interested parties are invited to review the document and send comments through 11 January 2024. Advisory Committee Representatives should consult their WBS questionnaires. Note that substantive technical comments were expected during the Candidate Recommendation review period that ended 20 July 2023.

the 11 January 2024 date is the one we need to fix up when we know the publication date, though I understand it might be generated automatically based on a specified publication date + fixed period.

@himorin
Copy link
Contributor

himorin commented Jan 23, 2024

Yes. Fixed period is at least 28days (for AC review).

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis that the dates will get fixed up during the PR publication process.

@nigelmegitt
Copy link
Contributor

Change made to close #78 - ideally this needs (re-)approvals @himorin , @andreastai , @palemieux if you agree with this change.

@himorin
Copy link
Contributor

himorin commented Jan 30, 2024

Change made to close #78 - ideally this needs (re-)approvals @himorin , @andreastai , @palemieux if you agree with this change.

changed statuses as r? from r+, but seems impossible to add @palemieux ...

Copy link

@andreastai andreastai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me

@nigelmegitt
Copy link
Contributor

seems impossible to add @palemieux ...

It's because he's the author of the PR. A comment from @palemieux about the change will be enough.

@palemieux
Copy link
Contributor Author

@himorin @nigelmegitt Ok to merge?

@himorin
Copy link
Contributor

himorin commented Jan 30, 2024

@himorin @nigelmegitt Ok to merge?

publishDate (and prEnd) have not been fixed yet. see also #78

@palemieux
Copy link
Contributor Author

publishDate (and prEnd) have not been fixed yet. see also #78

Can you provide dates?

@himorin
Copy link
Contributor

himorin commented Jan 30, 2024

as the same as last time you questioned, there is no solid answer but per best assumption: if CfC ends at 2024-02-12, transition request will be discussed and approved if there is no issue (e.g. IR as we discussed during call) around 2024-02-16, next publication slot is 2024-02-20. with 4 weeks, prEnd at 2024-03-19.

@nigelmegitt
Copy link
Contributor

@himorin @nigelmegitt Ok to merge?

Apologies, I don't think so, due to the late change 0114dfb and related CfC about allowing updates. When we know that's good and the transition request is modified and approved, we will know the dates and can update and merge this PR and make a release, to match the published Proposed Rec.

@palemieux
Copy link
Contributor Author

Ok. Just let me know. LGTM so far.

@nigelmegitt
Copy link
Contributor

CfC period for 0114dfb has now expired with no objections; as Chair, I declared Consensus to proceed with this as an updateable Rec in this email.

@himorin
Copy link
Contributor

himorin commented Feb 13, 2024

please use following lines (tentatively - could need to be updated per transition request discussion):

publishDate: "2024-02-20"
prEnd: "2024-03-19"

@nigelmegitt
Copy link
Contributor

See w3c/transitions#590 (comment)

@@ -195,7 +196,7 @@

<p>Furthermore, the model is not intended to constrain readability complexity.</p>
</section>
<section id='sotd'>
<section id='sotd' class='updateable-rec'>
<p>For this specification to exit the CR stage, one of the following minimum
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove these lines (lines 199-204 pre-pull request, 200-205 in the current commit) about CR exit from the PR version, or edit them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented at 436b4df

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, works for me. I have sent a short notice message to TTWG highlighting this change and proposing to proceed with this by end of Thursday 22nd February if there are no objections. I think we're very much in a "last minute editorial tweaks" phase here, which I'd very much like to emerge from as soon as possible!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections received. I'll confirm in a reply to that message; we can now continue with the CR exit criteria removed as per the current state of this pull request.

@palemieux palemieux merged commit 10624aa into main Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants