-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed Recommendation #77
Conversation
Improve note in Objective section Bump to PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, modulo the strange review date.
Should we still include the CR exit criteria in the PR, or should those be removed (from the SOTD section)? |
In short, yes. By testing locally, I've got respec error message for specStatus=PR without crEnd. Also a sentence like,
seems to be mandatory for PR publication. |
Thanks for that @himorin, then we should keep it. Looking at this text in the SOTD:
the 11 January 2024 date is the one we need to fix up when we know the publication date, though I understand it might be generated automatically based on a specified publication date + fixed period. |
Yes. Fixed period is at least 28days (for AC review). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on the basis that the dates will get fixed up during the PR publication process.
Change made to close #78 - ideally this needs (re-)approvals @himorin , @andreastai , @palemieux if you agree with this change. |
changed statuses as r? from r+, but seems impossible to add @palemieux ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me
It's because he's the author of the PR. A comment from @palemieux about the change will be enough. |
@himorin @nigelmegitt Ok to merge? |
publishDate (and prEnd) have not been fixed yet. see also #78 |
Can you provide dates? |
as the same as last time you questioned, there is no solid answer but per best assumption: if CfC ends at 2024-02-12, transition request will be discussed and approved if there is no issue (e.g. IR as we discussed during call) around 2024-02-16, next publication slot is 2024-02-20. with 4 weeks, prEnd at 2024-03-19. |
Apologies, I don't think so, due to the late change 0114dfb and related CfC about allowing updates. When we know that's good and the transition request is modified and approved, we will know the dates and can update and merge this PR and make a release, to match the published Proposed Rec. |
Ok. Just let me know. LGTM so far. |
CfC period for 0114dfb has now expired with no objections; as Chair, I declared Consensus to proceed with this as an updateable Rec in this email. |
please use following lines (tentatively - could need to be updated per transition request discussion):
|
spec/imsc-hrm.html
Outdated
@@ -195,7 +196,7 @@ | |||
|
|||
<p>Furthermore, the model is not intended to constrain readability complexity.</p> | |||
</section> | |||
<section id='sotd'> | |||
<section id='sotd' class='updateable-rec'> | |||
<p>For this specification to exit the CR stage, one of the following minimum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove these lines (lines 199-204 pre-pull request, 200-205 in the current commit) about CR exit from the PR version, or edit them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented at 436b4df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, works for me. I have sent a short notice message to TTWG highlighting this change and proposing to proceed with this by end of Thursday 22nd February if there are no objections. I think we're very much in a "last minute editorial tweaks" phase here, which I'd very much like to emerge from as soon as possible!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections received. I'll confirm in a reply to that message; we can now continue with the CR exit criteria removed as per the current state of this pull request.
Preview | Diff