-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constrain text emphasis position to 'outside' #16
Constrain text emphasis position to 'outside' #16
Conversation
@@ -159,7 +159,7 @@ <h3>Japanese Text Support</h3> | |||
<tr> | |||
<td><code>#textEmphasis-minimal</code></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there now a more expressive TTML2 feature designator we can use in place of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nigelmegitt What do you mean by "more expressive"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean one that more accurately maps to support for/use of the outside
value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the emphasis features relate specifically to the <emphasis-position>
component of tts:textEmphasis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see that the #textEmphasis-no-XXX
features are negative features rather than positive ones. I didn't notice that before. I think it's broken in TTML2 and will raise an issue for this: features should be positively stated not negatively, otherwise the future introduction of additional syntax and semantics will change the meaning of existing -no-XXX
style feature designators.
Raised as w3c/ttml2#697.
@@ -159,7 +159,7 @@ <h3>Japanese Text Support</h3> | |||
<tr> | |||
<td><code>#textEmphasis-minimal</code></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see that the #textEmphasis-no-XXX
features are negative features rather than positive ones. I didn't notice that before. I think it's broken in TTML2 and will raise an issue for this: features should be positively stated not negatively, otherwise the future introduction of additional syntax and semantics will change the meaning of existing -no-XXX
style feature designators.
Raised as w3c/ttml2#697.
index.html
Outdated
@@ -159,7 +159,7 @@ <h3>Japanese Text Support</h3> | |||
<tr> | |||
<td><code>#textEmphasis-minimal</code></td> | |||
|
|||
<td>none</td> | |||
<td>Only <code>outside</code> position semantics are required.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ambiguous: it could mean
- only position semantics are required, and only the value
outside
needs to be supported, OR - of the position semantics, only the value
outside
needs to be supported, butemphasis-style
does also need to be supported, barring quoted strings as excluded by#textEmphasis-minimal
Please could you clarify this @palemieux ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say (2).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will correct to of position semantics, only is supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@palemieux OK, looking forward to reviewing the change.
@nigelmegitt For your review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Close #15