Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aspect ratio of itts:fillLineGap figures #389

Closed
spoeschel opened this issue Jun 14, 2018 · 3 comments
Closed

Fix aspect ratio of itts:fillLineGap figures #389

spoeschel opened this issue Jun 14, 2018 · 3 comments
Assignees
@palemieux
Milestone
imsc1.1 CR2

Comments

@spoeschel
Copy link

When the two figures in 7.8.6 itts:fillLineGap are rendered by common browsers (e.g. Firefox or Chrome), they appear horizontally squeezed and the original aspect ratio gets lost.
@nigelmegitt
Copy link
Contributor

This doesn't happen at https://www.w3.org/TR/ttml-imsc1.0.1/#itts-fillLineGap but does happen at https://www.w3.org/TR/ttml-imsc1.1/#itts-fillLineGap - I haven't checked the difference, but that's a hint to find the fix.

@palemieux palemieux added this to the imsc1.1 CR2 milestone Jun 21, 2018
@palemieux palemieux mentioned this issue Jun 21, 2018
Closed
@palemieux
Copy link
Contributor

This is apparently a bug in base.css. See w3c/tr-design#156.

@palemieux palemieux removed the imsc1.1 label Jun 21, 2018
@nigelmegitt
Copy link
Contributor

@palemieux is it worth implementing the workaround at w3c/tr-design#156 (comment) or would that cause other problems?

palemieux added a commit that referenced this issue Jun 22, 2018
@palemieux
Apply workaround to <img> resize issue (w3c/tr-design#156) (#389)
9d6dc88
@palemieux palemieux mentioned this issue Jun 22, 2018
Merged
@palemieux palemieux self-assigned this Jun 26, 2018
palemieux added a commit that referenced this issue Jun 28, 2018
@palemieux
Apply workaround to <img> resize issue (#389)
0066401
@palemieux palemieux removed the pr open label Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palemieux palemieux

Labels
None yet
Projects
None yet
Milestone
imsc1.1 CR2
Development

No branches or pull requests
3 participants
@palemieux @nigelmegitt @spoeschel