Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarified links to EBU specifications and other miscellaneous edits #562

Merged
merged 3 commits into from
Jul 16, 2020
Merged

Clarified links to EBU specifications and other miscellaneous edits #562

merged 3 commits into from
Jul 16, 2020

Conversation

palemieux
Copy link
Contributor

@palemieux palemieux commented Jun 25, 2020 •
edited by pr-preview bot
Loading

Closes #560
Closes #561

Preview | Diff

@palemieux palemieux added this to the IMSC1.2-REC milestone Jun 25, 2020
@palemieux palemieux self-assigned this Jun 25, 2020
@himorin
Copy link
Contributor

himorin commented Jun 26, 2020

Could you add as editorial changes?, like https://www.w3.org/TR/2020/REC-wot-architecture-20200409/#changes-from-proposed-recommendation

@palemieux
Copy link
Contributor Author

Could you add as editorial changes?, like https://www.w3.org/TR/2020/REC-wot-architecture-20200409/#changes-from-proposed-recommendation

substantive-changes-summary.txt is updated.

@palemieux palemieux requested a review from himorin July 9, 2020 14:58
@palemieux
Copy link
Contributor Author

@himorin @nigelmegitt Looking forward to your review.

himorin
himorin approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@himorin himorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issue, also I could reach to all URLs which have put by this PR.

nigelmegitt
nigelmegitt reviewed Jul 13, 2020
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes all look good except I'm puzzled that there's no link to substantive-changes-summary.txt from the document. Shouldn't that exist somewhere?

@palemieux
Copy link
Contributor Author

The changes all look good except I'm puzzled that there's no link to substantive-changes-summary.txt from the document. Shouldn't that exist somewhere?

@nigelmegitt Added link in the SotD

nigelmegitt
nigelmegitt approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR Preview doesn't serve up substantive-changes-summary.txt but it needs to be put in the right place for publication anyway.

Thanks for the fix @palemieux - I'm approving because it looks good to me as a TTWG member, but it would be good if @chrisn could confirm too.

@chrisn
Copy link
Member

chrisn commented Jul 16, 2020

Thanks, @nigelmegitt. Looks good to me.

@palemieux palemieux merged commit 4cf38c2 into master Jul 16, 2020
@nigelmegitt nigelmegitt deleted the issues/0560-0561-misc-pr-edits branch July 17, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himorin himorin himorin approved these changes

@nigelmegitt nigelmegitt nigelmegitt approved these changes

Assignees

@palemieux palemieux

Labels
None yet
Projects
None yet
Milestone
IMSC1.2-REC
Development

Successfully merging this pull request may close these issues.

Links to EBU specifications IMSC 1.2 PR suggestions
4 participants
@palemieux @himorin @chrisn @nigelmegitt