-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addresses #84 #89
Addresses #84 #89
Conversation
@@ -431,7 +431,7 @@ | |||
<section id='ttp-aspectRatio'> | |||
<h4>ittp:aspectRatio</h4> | |||
|
|||
<p>The <code>ittp:aspectRatio</code> attributes allows authorial control of the mapping of the root container of a <a>Document Instance</a> to the <a>Related Video Object</a> frame.</p> | |||
<p>The <code>ittp:aspectRatio</code> attributes allows authorial control of the mapping of the root container of a <a>Document Instance</a> to each of the <a>Related Video Object</a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to say "each image frame of" rather than "each of"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Thanks.
Changed the note per the thread above. |
|
||
<div class="note">The mapping algorithm above allows the author to | ||
precisely control caption/subtitle position relative to elements within each frame of the video program, e.g. | ||
to match the position of actors. This mapping algorithm does not however specify the presentation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks as though the tests at https://www.w3.org/wiki/TimedText/IMSC1_Implementation_Report#Tests are based on verifying that implementations do indeed present the subtitles as specified. Are those tests still valid and required, or are we saying that this behaviour is canonically correct but that it is reasonable for some presentation implementations to behave differently to accommodate the situation when the image frame is not fully displayed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have re-reviewed this and now don't think there's anything in here that would invalidate the tests.
Resolves #84