Update loaf-explainer.md: explain blockingTime #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoavweiss
reviewed
Apr 11, 2023
loaf-explainer.md
Outdated
| @@ -223,6 +223,13 @@ const someLongAnimationFrameEntry = { | |||
| // [timestamp](https://dom.spec.whatwg.org/#dom-event-timestamp), i.e. the time it was queued | |||
| // which could be long before it was processed. | |||
| firstUIEventTimestamp, | |||
|
|
|||
| // The duration in milliseconds that the LoAF was blocking in practice. Since a LoAF can be consisted | |||
There was a problem hiding this comment.
Maybe something like:
"""
The duration in milliseconds that the animation frame was being blocked in practice.
Given that LoAFs can contain multiple tasks, we only consider as blocking:
- Long tasks.
- The longest task + the rendering time, if their sum exceeds the Long Task threshold of 50ms.
"""
yoavweiss
approved these changes
Apr 12, 2023
loaf-explainer.md
Outdated
| // Given that LoAFs can contain multiple tasks, we consider the following as blocking durations: | ||
| // * Long tasks | ||
| // * The longest task + the rendering time, if their sum exceeds the Long Task threshold of 50ms. | ||
| // The blockingDuration would be the sum of those long task durations, with 50ms subtracted form each. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.