-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GitHub Actions #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -338,7 +338,7 @@ Report long tasks {#report-long-tasks} | |||
1. Set |attribution|'s {{containerSrc}} attribute to the value of |container|'s <code>src</code> content attribute, or the empty string if the attribute is absent. | |||
1. If |container| is an <{object}> element: | |||
1. Set |attribution|'s {{containerType}} attribute to "<code>object</code>". | |||
1. Set |attribution|'s {{containerName}} attribute to the value of |container|'s <{object/name}> content attribute, or the empty string if the attribute is absent. | |||
1. Set |attribution|'s {{containerName}} attribute to the value of |container|'s <a href="https://html.spec.whatwg.org/multipage/iframe-embed-object.html#attr-object-name">name</a> content attribute, or the empty string if the attribute is absent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you file an HTML bug to disambiguate this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a comment on an existing issue I filed: whatwg/html#5958 (comment)
index.html
Outdated
@@ -1,1632 +0,0 @@ | |||
<!doctype html><html lang="en"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can probably add a .gitignore
to avoid adding the html output to the repo.
Also fix an ambiguous ref by adding a direct link because bikeshed says it's unable to distinguish.
Preview | Diff