Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions #91

Merged
merged 3 commits into from Nov 30, 2020
Merged

Use GitHub Actions #91

merged 3 commits into from Nov 30, 2020

Conversation

npm1
Copy link
Contributor

@npm1 npm1 commented Nov 27, 2020

Also fix an ambiguous ref by adding a direct link because bikeshed says it's unable to distinguish.


Preview | Diff

@npm1 npm1 requested a review from yoavweiss November 27, 2020 20:20
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -338,7 +338,7 @@ Report long tasks {#report-long-tasks}
1. Set |attribution|'s {{containerSrc}} attribute to the value of |container|'s <code>src</code> content attribute, or the empty string if the attribute is absent.
1. If |container| is an <{object}> element:
1. Set |attribution|'s {{containerType}} attribute to "<code>object</code>".
1. Set |attribution|'s {{containerName}} attribute to the value of |container|'s <{object/name}> content attribute, or the empty string if the attribute is absent.
1. Set |attribution|'s {{containerName}} attribute to the value of |container|'s <a href="https://html.spec.whatwg.org/multipage/iframe-embed-object.html#attr-object-name">name</a> content attribute, or the empty string if the attribute is absent.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you file an HTML bug to disambiguate this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a comment on an existing issue I filed: whatwg/html#5958 (comment)

index.html Outdated
@@ -1,1632 +0,0 @@
<!doctype html><html lang="en">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably add a .gitignore to avoid adding the html output to the repo.

@npm1 npm1 merged commit 1031306 into w3c:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants