-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop density descriptor from spec #450
Comments
I agree. The |
at manifoldjs we see very few devs using this. I know one of the generation tools will insert this in for you, but generally I see it left out. Likewise, I don't see "types" used often by developers, as it's normally determined by the extension type of the image. |
Doesn't removing this break parity with |
Discussing with @seksenov and @boyofgreen ... |
A little, yes. But the use case is a little bit different and I think it would be better we address this now, rather than having to change the semantics of the member (its current usage is meaningless to the UA, so we'd have to ignore it in practice). If later people start asking for this feature, we can add it back in once more developers understand its utility (and why it was there in the first place). |
Chrome actually uses |
Feat(density): remove density member (closes #450)
@kenchris or @mounirlamouri, I've sent a patch to have this removed from Gecko: Can you do the same on the Blink side pretty please 🍒. |
Opened a bug: https://crbug.com/603848 |
FTR, Chrome dropped support for 'density'. It will no longer be used in Chrome 52. |
The density member was dropped from the W3C spec. Support has been removed from both Chrome and Firefox. See: w3c/manifest#450 It is also incorrectly used in this manifest.
Cross-linking this here because I was having a hard time finding this: this has been re-discussed over on #118, and there are two reasons to not reverse this decision:
|
There seems to be a lot of confusion about how to properly use the
density
member. It was designed to support discriminating against the user's screen: that is to say, if the end-user screen greater than or equal to X, then use this icon.When we started this effort a few years ago, this use case was driven by iOS developers that were having to create specific icons for 1x and 2x - not only for performance, but because 2x icons were getting scaled incorrectly in 1x displays. However, this is a bit of an edge case nowadays because most phones have +2x displays.
Because of misuse and confusion around this feature, we are seeing a lot that is using density as a descriptor of the icon instead. E.g., a 36x36 pixel icon is "0.75"... which doesn't make any sense. Anyway, this gets worst for larger icons, where some developers have specified things like "density": "4" - where those icons would be fine to use on a 2x density display.
As such, I propose we drop density from the spec.
@mounirlamouri, @kenchris, @RobDolinMS, @boyofgreen, wdyt?
The text was updated successfully, but these errors were encountered: