Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ordered map JSON in id processing #1040

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Use ordered map JSON in id processing #1040

merged 1 commit into from
Jul 20, 2022

Conversation

philloooo
Copy link
Collaborator

@philloooo philloooo commented Jun 2, 2022 •
edited by pr-preview bot
Loading

Use ordered map instead of object type for consistency with all other processing logic.

This change (choose at least one, delete ones that don't apply):

  • Is a "chore" (metadata, formatting, fixing warnings, etc).

Commit message:

Use ordered map JSON in id processing

Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:

  • chore:
  • editorial:
  • BREAKING CHANGE:
  • And use none if it's a normative change

Preview | Diff

@marcoscaceres marcoscaceres self-assigned this Jul 20, 2022
@marcoscaceres marcoscaceres merged commit 5aba379 into main Jul 20, 2022
@marcoscaceres marcoscaceres deleted the philloooo-patch-1 branch July 20, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

@aarongustafson aarongustafson Awaiting requested review from aarongustafson

Assignees

@marcoscaceres marcoscaceres

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philloooo @marcoscaceres