[Index | Example] Add Service Worker object #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the service worker object to the complex example @kenchris (or others) - would you please comment if you think scope should be: a) "/racer" - matching example in serviceworker section b) "/racer/" - matching the `scope` object earlier in the example Signed-off-by: Rob Dolin <robdolin@microsoft.com>
|
I would assume that they mean the same, assuming /races is a dictionary. If it is not, it won't work in any of the cases. https://webmasters.googleblog.com/2010/04/to-slash-or-not-to-slash.html Does the SW spec say anything about this? |
|
For the example, I think it makes more sense to use /races/ because that makes it clear it is a dictionary |
"serviceworker" | `"scope": "/racer"` --> "serviceworker" | `"scope": "/racer/"` Matches `"scope": "/racer/"` Signed-off-by: Rob Dolin <robdolin@microsoft.com
|
Thanks @kenchris. I've updated the example your suggestion. |
marcoscaceres
approved these changes
Mar 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the service worker object to the complex example
@kenchris (or others) - would you please comment if you think scope should be:
a) "/racer" - matching example in serviceworker section
b) "/racer/" - matching the
scopeobject earlier in the exampleSigned-off-by: Rob Dolin robdolin@microsoft.com