Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payment handler installation URL. #634

Closed
wants to merge 1 commit into from

Conversation

rsolomakhin
Copy link

@rsolomakhin rsolomakhin commented Jan 3, 2018

This patch adds a payment_handler_install_url to the webapp manifest. A user agent may use this URL for just-in-time installation of a payment handler as described in w3c/payment-handler#240.


Preview | Diff

@rsolomakhin
Copy link
Author

@marcoscaceres & @domenic: please take a look.

@zkoch
Copy link

zkoch commented Jan 4, 2018

Hm, isn't there already a serviceworker member inside of the manifest spec? Why do we need something else?

@kenchris
Copy link
Collaborator

kenchris commented Jan 4, 2018

There is :)

@domenic
Copy link
Contributor

domenic commented Jan 4, 2018

Yeah, fair point, sorry I didn't catch that earlier. I might be missing something and there might be some reason it'd be separate, but I think that the existing serviceworker member would make sense here.

@rsolomakhin
Copy link
Author

The payment_handler_install_url member is the HTML page that installs the service worker and sets up the payment instruments. The serviceworker member does not have an equivalent.

@marcoscaceres
Copy link
Member

could the start_url just be this? I’m concerned about adding additional complexity.

@rsolomakhin
Copy link
Author

Sounds good. CC @anthonyvd on this decision. Closing this PR.

@rsolomakhin rsolomakhin closed this Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants