editorial: fix a broken local reference #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable "local-refs-exist" ReSpec linter rule
|
@marcoscaceres can you have a look |
marcoscaceres
changed the title
marcoscaceres
changed the title
This is for the manifest link type... which we need to add to HTML
marcoscaceres
requested changes
May 30, 2018
index.html
Outdated
| "no-headingless-sections": true, | ||
| "privsec-section": true, | ||
| "no-http-props": true, | ||
| "local-refs-exist": true, |
There was a problem hiding this comment.
We probably only need this one, not the rest... they are enabled by default.
|
@kenchris, other Editors 👋: @sidvishnoi is an intern working with Mozilla on ReSpec over the summer as part of Google Summer of Code. You'll see him pop up with helpful ReSpec goodies from time to time. Please make him feel welcome and, where possible, please review his incoming PRs. |
|
Ah, great to know! 🎆 |
|
Marked as non substantive for IPR from ash-nazg. |
marcoscaceres
approved these changes
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enabled
local-refs-existlint rule to prevent broken references in futurePreview | Diff