Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Consistently use abort not terminate #810

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Editorial: Consistently use abort not terminate #810

merged 2 commits into from
Oct 10, 2019

Conversation

janiceshiu
Copy link
Contributor

@janiceshiu janiceshiu commented Oct 9, 2019 •
edited by pr-preview bot
Loading

Closes #809

This change (choose one):

  • Breaks existing normative behavior (please add label "breaking")
  • Adds new normative requirements
  • Adds new normative recommendations or optional items
  • Makes only editorial changes (only changes informative sections, or
    changes normative sections without changing behavior)
  • Is a "chore" (metadata, formatting, fixing warnings, etc).

Commit message:
standardise 'terminate' to 'abort'

Preview | Diff

@marcoscaceres
Copy link
Member

Marked as non substantive for IPR from ash-nazg.

@marcoscaceres marcoscaceres self-requested a review October 10, 2019 02:49
marcoscaceres
marcoscaceres approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @contrepoint! thank you!

@marcoscaceres marcoscaceres merged commit 75a0f47 into w3c:gh-pages Oct 10, 2019
christianliebel pushed a commit to christianliebel/manifest that referenced this pull request May 27, 2020
@janiceshiu @christianliebel
Editorial: Consistently use abort not terminate (w3c#810)
15058c3 
* Editorial: in section 7.1, change 'terminate' to 'abort'
* Editorial: in section 2.4, change 'terminate' to 'abort'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent use of "terminate" vs "abort"
2 participants
@janiceshiu @marcoscaceres