Fix #136: Remove at-risk TrackDefault feature and related spec text #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in #136, we can revert this if the CfC for this feature's removal from MSE v1 fails. Alternatively, we can revert this in a branch for VNext to continue work on refining and implementing this feature.
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Aug 12, 2017
Arrays were removed from the WebIDL spec in 2015. TrackDefault itself is no longer part of the MSE spec since w3c/media-source#138; while it is not removed from Blink, go for the safest approach and just replace the DOMString array from the IDL with an `object' and move the array -> V8 object conversion to the C++ side. This avoids any user-visible changes. Bug: 619665 Change-Id: Idfa232feb780034bdd9ff6d631cd026189d6f1a6 Reviewed-on: https://chromium-review.googlesource.com/612250 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#493799}
ddbeck
added a commit
to maboa/browser-compat-data
that referenced
this pull request
Jul 5, 2018
It looks like this API is being reworked: w3c/media-source#138
ddbeck
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Jul 5, 2018
* Add compat data for TrackDefault * Set to not standard track It looks like this API is being reworked: w3c/media-source#138
ddbeck
added a commit
to maboa/browser-compat-data
that referenced
this pull request
Jul 7, 2018
This API was dropped from the current spec. See w3c/media-source#138
ddbeck
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Jul 7, 2018
* Add compat data for TrackDefaultList * Change TrackDefaultList to non-standard track This API was dropped from the current spec. See w3c/media-source#138
sideshowbarker
added a commit
to w3c/browser-compat-data
that referenced
this pull request
Jan 29, 2020
w3c/media-source#138 removed the trackDefaults member from the SourceBuffer interface. w3c/media-source@ed76bbd
queengooborg
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Jan 30, 2020
w3c/media-source#138 removed the trackDefaults member from the SourceBuffer interface. w3c/media-source@ed76bbd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #136, we can revert this if the CfC for this feature's
removal from MSE v1 fails. Alternatively, we can revert this in a branch
for VNext to continue work on refining and implementing this feature.