Wolenetz adding to mwatson2 issue 83 in wolenetz repo #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even with the relatively insignificant linking of the "ReadyState" type of the "readyState" attribute detail to the readyState IDL section instead of the ReadyState enum, this LGTM. I'll merge it shortly to fix #83. Thank you, @mwatson2, for doing the bulk of the work on this, and @jdsmith3000 for helping with the difficult review of this. |
wolenetz
deleted the
wolenetz_adding_to_mwatson2_issue_83_in_wolenetz_repo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces PR #127 while mwatson2 is OOO, so that I can land it with minor review changes/merge conflict resolution/etc.