Set [Restrictable] on the video track #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should there be a PR on element capture as well? |
There was: screen-share/element-capture#49 |
youennf
reviewed
Sep 26, 2024
There was a problem hiding this comment.
Looks ok to me.
Overall, I feel like we should use https://w3c.github.io/mediacapture-main/#dfn-create-a-mediastreamtrack here, and pass the restrictable value to it.
Great!
If you feel strongly, I am not opposed. But please consider that the current change is less intrusive, and could be rolled back more easily if need be, with less changes to other specs. |
jan-ivar
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This marks video tracks obtained using getViewportMedia() as eligible tracks for Element Capture.
Preview | Diff