add 'ZIP' clarification and other editorials #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xfq
approved these changes
May 9, 2020
|
Conflicts solved, pls proceed... |
xfq
reviewed
May 14, 2020
| <h2>app</h2> | ||
| <p>app manages all MiniApp pages and global data, as well as MiniApp’s lifecycle management. It contains logic (app.js), configuration (manifest.json) and css (app.css). | ||
| </p> | ||
| <h2>root files</h2> |
There was a problem hiding this comment.
I think "root directory" is better than "root folder".
There was a problem hiding this comment.
actually, I put 'files' instead of 'folder' since there is no such 'root' folder (or directory) per se.
xfq
reviewed
May 14, 2020
specs/packaging/index.html
Outdated
| <p>page represents each of MiniApp pages, responsible for MiniApp page display and user interaction. It contains logic (page.js), configuration (page.json), structure (page.xml) and css (page.css). | ||
| <h2>pages</h2> | ||
| <p> | ||
| The <code>pages</code> folder contains sets of files for the display and user interaction of all MiniApp pages. Each set of files that shares the same base file name (e.g. 'page1') with different extension names describe a particular page on different aspects, such as the service logic (e.g. page1.js), the configuration (e.g. page1.json), the structure (e.g. page1.xml) and the style (e.g page1.css). Developers can choose to put all page files directly under the <code>pages</code> folder in a flat manner, or organize them in different sub-folders for different pages. |
There was a problem hiding this comment.
I think "directory" is better than "folder" here, since "directory" is a file system concept, and "folder" is the graphical user interface metaphor that is used to represent a directory. (Same below.)
There was a problem hiding this comment.
I can agree to change 'folder' as 'directory'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to address ISSUE#39 and improve the text.
@QingAn @ShourenLan @xfq @zhiqiangyu