-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate spec and "By Example" to new docs system #223
Comments
@adrianholovaty Thanks for working on this. Regarding the MusicXML examples on the previous page "MNX By Example", they were very illustrative and useful to compare and assess the changes. I would vote to keep them on the new pages when convenient, side by side as they were on the old pages, if it is possible and their maintenance does not require excessive work. |
@cecilios Thanks for the thoughts. Yes, I agree the comparisons with MusicXML are very useful! |
Here's my TODO list for the MNX by Example examples, starting from the current (readonly) examples:
|
@adrianholovaty Your first TODO says
Merging PR #213 into the master branch now would stabilize the spec, and probably save some future work. |
Status update: As of 028c8b9, the new docs system now has a Comparing MNX and MusicXML page, which is essentially a replacement for the old MNX By Example page. The new page has some new features:
It may be slightly confusing for each example to live in two places ("Comparing MNX and MusicXML" plus the examples section), but I think there's benefit in having all of the MusicXML comparisons on a single page, for easy, tutorial-style consumption by somebody new to MNX. I expect we'll tweak the way this works at some point, especially as the number of examples grows. Remaining todos for this line of work:
Once those last todos are done, I'll remove the old MNX By Example page and redirect it to the new page. |
Status update: As of 8a02d35, the new docs system's Comparing MNX and MusicXML page now has the "Show relevant section" vs. "Show full document" logic. This is created dynamically; the system looks for a magic Just one thing remaining before I can redirect the old By Example page to this new page: adding a way to specify ordering of the examples. |
This is really cool. Nice work! |
The following examples are either missing from the above list or need to be updated:
As per my TODO list above, I have now created a new example showing how to group parts. According to this example, all the MNX examples need to be updated. See #185 (comment). |
Status update: As of 7cbab68, "MNX By Example" has been fully replaced by the (essentially identical) version in the new docs system. See the commit message for more details. The old URL has been redirected to the new one. |
This work was done a little while ago (see also #253). |
This GitHub issue serves as a general holding place for remaining to-dos in migrating our docs.
As of 2021-01-21, the doc system is still in progress but is already capable of:
See the docgenerator README for more details. You can browse the new docs here.
Remaining to-dos are:
The text was updated successfully, but these errors were encountered: