Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNX by Example: Beams (with inner grace note) #225

Closed
notator opened this issue Jan 21, 2021 · 3 comments
Closed

MNX by Example: Beams (with inner grace note) #225

notator opened this issue Jan 21, 2021 · 3 comments

Comments

@notator
Copy link
Contributor

notator commented Jan 21, 2021

This is an edit of the existing "Beams (with inner grace notes)" example that

  1. includes the grace note encoding.
  2. includes a '#' character at the start of each reference to a local ID.
  3. reduces the height of the screenshot staff to that of the other examples in this series.

beamAroundGraceNote

<mnx>
    <global>
        <measure>
            <directions>
                <time signature="4/4"/>
            </directions>
        </measure>
    </global>
    <part>
        <part-name>Music</part-name>
        <measure>
            <directions>
                <clef line="2" sign="G"/>
            </directions>
            <sequence>
                <beams>
                    <beam events="#ev1 #ev3 #ev4 #ev5"/>
                </beams>
                <event id="ev1" value="/8">
                    <note pitch="C5"/>
                </event>
                <grace>                
                    <event value="/8">
                        <note pitch="B4"/>
                    </event>
                </grace>
                <event id="ev3" value="/8">
                    <note pitch="D5"/>
                </event>
                <event id="ev4" value="/8">
                    <note pitch="E5"/>
                </event>
                <event id="ev5" value="/8">
                    <note pitch="F5"/>
                </event>
                <event value="/2">
                    <rest/>
                </event>
            </sequence>
        </measure>
    </part>
</mnx>
@adrianholovaty
Copy link
Contributor

Thanks @notator. I've updated the new docs in commit 1a903cc. This involved adding <grace> to the new docs system and updating the "Beams (with inner grace note)" example to use <grace> properly.

I didn't update the image, as I don't think we should endeavor to make every screenshot image have the same height. In practice that's not going to be feasible given the wealth of examples we'll have — so I don't want to set the expectation that we'll be doing that. We can always set screenshots' width and height via CSS in the docs.

Regarding your change to add "#" to the ID list — could you remind me of why you're suggesting that?

@notator
Copy link
Contributor Author

notator commented Jan 23, 2021

The discussion on hash tags begins with a comment from @ahankinson at #190 (comment). :-)

@adrianholovaty
Copy link
Contributor

Thanks. I don't see a good reason to add/require those hash marks. It makes the parsing slightly more annoying for developers and doesn't offer any strong benefit.

Marking this pull request as closed, now that the docs have been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants