-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify use of mDNS, QUIC, and CBOR #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks good! See inline comments for typos.
Co-Authored-By: pthatcherg <pthatcherg@users.noreply.github.com>
Co-Authored-By: pthatcherg <pthatcherg@users.noreply.github.com>
Co-Authored-By: pthatcherg <pthatcherg@users.noreply.github.com>
Co-Authored-By: pthatcherg <pthatcherg@users.noreply.github.com>
Co-Authored-By: pthatcherg <pthatcherg@users.noreply.github.com>
Co-Authored-By: pthatcherg <pthatcherg@users.noreply.github.com>
Co-Authored-By: pthatcherg <pthatcherg@users.noreply.github.com>
Co-Authored-By: pthatcherg <pthatcherg@users.noreply.github.com>
Co-Authored-By: pthatcherg <pthatcherg@users.noreply.github.com>
Wow, so apparently making everything a "single comment" had disastrous consequences. I'm new to reviewing on GitHub, so sorry for the spam! |
Co-Authored-By: pthatcherg <pthatcherg@users.noreply.github.com>
…screenprotocol into filling-out-spec
Co-Authored-By: pthatcherg <pthatcherg@users.noreply.github.com>
…screenprotocol into filling-out-spec
Co-Authored-By: pthatcherg <pthatcherg@users.noreply.github.com>
I'll install bikeshed and run it tomorrow. In the meantime, there are a few things remaining for discussion but I think I've resolved most of them. |
Added biblio.json for references not in specref
…screenprotocol into filling-out-spec
This conversation/review has gotten complex enough that I'm having trouble tracking all of the things going on. I think that we're close enough to being in a good state that we should merge the PR and then resolve anything unresolved with issues and or separate PRs. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with a couple of typos to fix
index.bs
Outdated
Listening agents act as QUIC clients. Advertising agents act as QUIC servers. | ||
|
||
If a listening agent wishes to receive messages from an advertising agent or an | ||
advertising agent wishes to send message to a listening agent, it may wish to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/message/messages/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
No description provided.