Convert HTMLMediaElements links to autolinks #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update converts all explicit references to the HTML spec to Bikeshed's autolinks syntax. To render the name of the interface along with the name of the attribute or method, the "visible text" syntax is used (the text after `|`). The notions of "media error code", official playback position", "poster frame" and "timeline offset" are not HTMLMediaElement attributes but rather internal HTML concepts whose definitions are not currently exported. Longer term, we should make sure that the HTML spec exports these terms (unless we don't need them anymore). The text incorrect referred to a `stalled` attribute that does not exist, instead of to the `stalled` event. Text updated accordingly.
markafoltz
approved these changes
Mar 10, 2021
|
I am going to merge this PR since it is approved by @mfoltzgoogle |
github-actions bot
added a commit
that referenced
this pull request
Mar 15, 2021
…LMediaElements links to autolinks SHA: a332409 Reason: push, by @louaybassbouss Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update converts all explicit references to the HTML spec to Bikeshed's autolinks syntax. To render the name of the interface along with the name of the attribute or method, the "visible text" syntax is used (the text after
|).The notions of "media error code", official playback position", "poster frame" and "timeline offset" are not HTMLMediaElement attributes but rather internal HTML concepts whose definitions are not currently exported. Longer term, we should make sure that the HTML spec exports these terms (unless we don't need them anymore).
The text incorrect referred to a
stalledattribute that does not exist, instead of to thestalledevent. Text updated accordingly.This would address #264.
Preview | Diff