Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address remote playback issues. #313

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Address remote playback issues. #313

merged 4 commits into from
Jan 22, 2024

Conversation

mfoltzgoogle
Copy link
Contributor

@mfoltzgoogle mfoltzgoogle commented Sep 10, 2023 •
edited by pr-preview bot

This PR addresses Issues #223 and #265

  • It changes the remote playback state / controls to include the full media resource (URL + mime type), so that the sender can change the media resource after remote playback has started.
  • It describes what the sender needs to do to change the encoding for a stream after a streaming session has started.
  • It makes the source optional for a remote-playback-start-request if the remote playback begins with media remoting (streaming session)

Note, I'm wondering if remote-playback-controls should have a list of sources like the remote-playback-start-request...

Preview | Diff

@mfoltzgoogle mfoltzgoogle linked an issue Sep 11, 2023 that may be closed by this pull request
[Remote Playback] Refinements to Remote Playback protocol #159
Closed
@mfoltzgoogle mfoltzgoogle removed a link to an issue Sep 11, 2023
[Remote Playback] Refinements to Remote Playback protocol #159
Closed
This was linked to issues Sep 11, 2023
Codec switching when remoting. #223
Closed
Should media resource URLs be optional? #265
Closed
@mfoltzgoogle
Copy link
Contributor Author

@baylesj Do you mind reviewing this one as well?
@muyao-xu as this impacts the Remote Playback API.

baylesj
baylesj approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@baylesj baylesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % feedback.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@mfoltzgoogle
Copy link
Contributor Author

PTAL

baylesj
baylesj approved these changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@baylesj baylesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mfoltzgoogle mfoltzgoogle merged commit 58e109c into main Jan 22, 2024
2 checks passed
@mfoltzgoogle mfoltzgoogle deleted the issue-223-codec-switching branch January 22, 2024 18:13
github-actions bot added a commit that referenced this pull request Jan 22, 2024
@mfoltzgoogle @github-actions
Merge pull request #313 from w3c/issue-223-codec-switching
39af3d4 
SHA: 58e109c
Reason: push, by mfoltzgoogle

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baylesj baylesj baylesj approved these changes

Assignees

@baylesj baylesj

Labels
v1-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should media resource URLs be optional? Codec switching when remoting.
2 participants
@mfoltzgoogle @baylesj