Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description of model section #2

Merged
merged 1 commit into from
Mar 7, 2017

Conversation

alexshalamov
Copy link

  • Improve description of model section
  • Add graphical example for relation of Earth's and device's coordinate systems

index.bs Outdated
The elements of the [=list=] are equal to components of a unit quaternion representing orientation
of the device in a three dimensional Cartesian coordinate system (x, y, z), where x-axis points east,
y-axis points north and z-axis points up and is perpendicular to the plane made up of x and y axis.
The elements of the [=list=] are equal to components of a unit quaternion [cos(θ/2), x**sin(θ/2), y*sin(θ/2), z*sin(θ/2)]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a ref for "unit quaternion"?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe better [cos(θ/2), Vx sin(θ/2), Vy sin(θ/2), Vz sin(θ/2)], where V is the unit vector representing the axis of rotation

- Improve description of model section
- Add graphical example for relation between Earth's and device's coordinate systems
@anssiko
Copy link
Member

anssiko commented Mar 7, 2017

LGTM. Bonus points for referencing my favourite paper.

@alexshalamov alexshalamov merged commit 4108830 into w3c:gh-pages Mar 7, 2017
y-axis points north and z-axis points up and is perpendicular to the plane made up of x and y axis.
The elements of the [=list=] are equal to components of a unit quaternion [[QUATERNIONS]]
[cos(θ/2), V<sub>x</sub> * sin(θ/2), V<sub>y</sub> * sin(θ/2), V<sub>z</sub> * sin(θ/2)] where V is the unit vector representing
the axis of rotation. The quaternion represents rotation of a device hosting motion sensors in relation to a <dfn>Earth's reference coordinate system</dfn> defined as a three
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe say that the first component is the scalar representing the actual rotation angle


- x-axis is a vector product of y.z that is tangential to the ground and points east.
- y-axis is tangential to the ground and points towards magnetic north.
- z-axis points towards the sky and is perpendicular to the plane made up of x and y axes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the z-axis would normally be called a normal vector of that plane

@@ -18,18 +18,53 @@ Version History: https://github.com/w3c/orientation-sensor/commits/gh-pages/inde
Indent: 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the perspective of the phone sides on that picture in comparison with the earth, looks all wrong. The phone looks like it lays flat on the surface, but the sides tell another story... the sides should be parallel with the z axis

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can improve it later if required, or you can open issue or PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants