Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTP matching rules: don't remove pt_table[packet.pt] #550

Closed
wants to merge 2 commits into from
Closed

RTP matching rules: don't remove pt_table[packet.pt] #550

wants to merge 2 commits into from

Conversation

aboba
Copy link
Contributor

@aboba aboba commented May 19, 2016

Fix for Issue #547

@ibc
Copy link
Contributor

ibc commented May 19, 2016

This commit just removes the comment/question. It still set <var>pt_table</var>[<var>packet.pt</var>] to null so the issue describes in #547 persists.

@aboba
Do not set pt_table entry to null
a5af70d 
Do not set pt_table entry to null
@aboba
Copy link
Contributor Author

aboba commented May 19, 2016

@ibc updated. Should be fixed now.

@ibc
Copy link
Contributor

ibc commented May 20, 2016

LGTM

@aboba
Copy link
Contributor Author

aboba commented May 31, 2016

Consolidating matching rules PRs. Now incorporated into PR #555

@aboba aboba closed this May 31, 2016
@ibc
Copy link
Contributor

ibc commented May 31, 2016

Perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aboba @ibc