Add QUIC transport #600
Closed
Add QUIC transport #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very rough PR to add support for QUIC transport. Not ready to merge. Related to Issue #584
small fixes
More fixes
typedef (RTCDtlsTransport or RTCQuicTransport) RTCTransport;
Add typedef for RTCTransport
pthatcherg
reviewed
Oct 26, 2016
| @@ -2564,7 +2564,7 @@ | |||
| <h3>Operation</h3> | |||
| <p>A <code><a>RTCRtpSender</a></code> instance is constructed from an | |||
| <a>MediaStreamTrack</a> object and associated to an | |||
| <code><a>RTCDtlsTransport</a></code>. If an attempt is made to construct an | |||
| <code><a>RTCTransport</a></code>. If an attempt is made to construct an | |||
There was a problem hiding this comment.
If this is for sending SRTP, why not call it an RTCSrtpTransport or RTCSecureTransport (just like we've done for RTCDataTransport for data channels)? Then have both DtlsTransport and QuicTransport inherit from it and you don't need the typedef.
pthatcherg
reviewed
Oct 26, 2016
| @@ -7724,6 +7731,429 @@ | |||
| </pre> | |||
| </section> | |||
| </section> | |||
| <section id="rtcquictransport*"> | |||
There was a problem hiding this comment.
Where will the mapping from RTP/RTCP to QUIC streams be defined?
pthatcherg
reviewed
Oct 26, 2016
| <pre class="idl"> | ||
| [ Constructor (RTCIceTransport transport, sequence<RTCCertificate> certificates)] | ||
| interface RTCQuicTransport : RTCStatsProvider { | ||
| readonly attribute FrozenArray<RTCCertificate> certificates; |
There was a problem hiding this comment.
Shouldn't an RTCQuicTransport also be an RTCDataTransport?
pthatcherg
reviewed
Oct 26, 2016
| interface RTCQuicTransport : RTCStatsProvider { | ||
| readonly attribute FrozenArray<RTCCertificate> certificates; | ||
| readonly attribute RTCIceTransport transport; | ||
| readonly attribute RTCQuicTransportState state; |
There was a problem hiding this comment.
Where will the mapping from data messages to QUIC streams be defined?
pthatcherg
suggested changes
Oct 26, 2016
Add implementation note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very early PR to add support for QUIC transport. Not ready to merge.
Related to Issue #584
Missing pieces: