Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(perm interface): Fix return value handling #143

Closed
wants to merge 1 commit into from

Conversation

jugglinmike
Copy link
Contributor

Unlike the other methods defined in this section, revoke is defined as
a series of steps to be run in parallel. Returning a value is
meaningless in this context. Instead, the result of the operation should
be communicated via the Promise instance that is defined and
synchronously returned prior to the parallelized steps.

Unlike the other methods defined in this section, `revoke` is defined as
a series of steps to be run in parallel. Returning a value is
meaningless in this context. Instead, the result of the operation should
be communicated via the Promise instance that is defined and
synchronously returned prior to the parallelized steps.
@jyasskin
Copy link
Member

Sorry it took me so long to look at this. The "real" problem here is that revoke shouldn't run all of its steps in parallel. We're specifically not allowed to use "converted to an IDL value" from parallel steps, since ECMAScript objects are single-threaded.

It should go parallel before step 3, and then have step 5 call into the middle of query() with the already-converted typedDescriptor.

I'm finally working on pulling request() and revoke() into an incubation, and I'll fix this there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants