-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and respec fixes #441
Conversation
- add `class="export"` to definitions to export - add `<dfn>` and `data-lt="..."` synonims/aliases where appropriate - eliminate most hardcoded `href="#..."` relative links in favour of autogenerated respec definition links Closes #435
Not a super expert on respec, nor on the whole "which things should/shouldn't be 'exported' from a spec" aspect. so please have a close look particularly at that aspect. Assuming the changes are good though, this eliminates all previous Respec errors we were having (and tidies up some of the hardcoded relative links, which always irked me a bit) |
Also shout if there was a reason for having that "candidate regions" part of the heading that escaped me...but to me that was never really necessary? |
@smaug---- yup, keep 'em coming. i was naively adding exports to "things that somebody may potentially want to point to from the outside", but i probably overestimated how interesting/relevant they might be from an outside perspective. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd drop perhaps those few exports
d0aa843
to
c0ed3d8
Compare
this was also preventing pr-preview from running correctly. with thanks to Denis Ah Kang for spotting the broken link.
@flackr @mustaqahmed you ok with these changes? i'll merge these end of today unless I hear otherwise if that's ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks.
…r and prose to include declare/declaratively
<td>Yes</td> | ||
<td>No</td> | ||
<td>None</td> | ||
</tr> | ||
</tbody> | ||
</table> | ||
|
||
<p>Viewport manipulations (panning and zooming) — generally, as a result of a <a>direct manipulation</a> interaction — are intentionally NOT a default action of pointer events, meaning that these behaviors (e.g. panning a page as a result of moving a finger on a touchscreen) cannot be suppressed by canceling a pointer event. Authors must instead use <code>touch-action</code> to explicitly <a href="#declaring-candidate-regions-for-direct-manipulation-behaviors">declare the direct manipulation behavior</a> for a region of the document. Removing this dependency on the cancelation of events facilitates performance optimizations by the user agent.</p> | ||
<p>Viewport manipulations (panning and zooming) — generally, as a result of a <a>direct manipulation</a> interaction — are intentionally NOT a default action of pointer events, meaning that these behaviors (e.g. panning a page as a result of moving a finger on a touchscreen) cannot be suppressed by canceling a pointer event. Authors must instead use <code>touch-action</code> to explicitly <a>declare the direct manipulation behavior</a> for a region of the document. Removing this dependency on the cancelation of events facilitates performance optimizations by the user agent.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more nit, sorry: the "the" in "declare the direct manipulation behavior" sounds a bit odd to me because at this point the behavior is not defined to the reader. Perhaps this is only me, but calling our regardless.
class="export"
to definitions to export<dfn>
anddata-lt="..."
synonyms/aliases where appropriatehref="#..."
relative links in favour of autogenerated respec definition links<dfn>
to link to)data-cite
nothref
for Respec to do its magic)Closes #435
💥 Error: 502 Bad Gateway 💥
PR Preview failed to build. (Last tried on Jun 1, 2022, 2:56 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.