Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and respec fixes #441

Merged
merged 5 commits into from Jun 1, 2022
Merged

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented May 29, 2022

  • add class="export" to definitions to export
  • add <dfn> and data-lt="..." synonyms/aliases where appropriate
  • eliminate most hardcoded href="#..." relative links in favour of autogenerated respec definition links
  • remove the "candidate regions" bit from the "Declaring candidate regions for direct manipulation behaviors" heading - now that section is just "Declaring direct manipulation behaviors" (not sure why the "candidate regions" bit was needed, and always sounded a bit too wishy-washy...why "candidates"? also made it easier to then set it as a clean <dfn> to link to)
  • fix some markup validation issues/misnestings
  • fix a broken link to UIEVENTS Mouse Event Order (use data-cite not href for Respec to do its magic)

Closes #435


💥 Error: 502 Bad Gateway 💥

PR Preview failed to build. (Last tried on Jun 1, 2022, 2:56 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL

<html><body><h1>502 Bad Gateway</h1>
The server returned an invalid or incomplete response.
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

- add `class="export"` to definitions to export
- add `<dfn>` and `data-lt="..."` synonims/aliases where appropriate
- eliminate most hardcoded `href="#..."` relative links in favour of autogenerated respec definition links

Closes #435
@patrickhlauke
Copy link
Member Author

Not a super expert on respec, nor on the whole "which things should/shouldn't be 'exported' from a spec" aspect. so please have a close look particularly at that aspect.

Assuming the changes are good though, this eliminates all previous Respec errors we were having (and tidies up some of the hardcoded relative links, which always irked me a bit)

@patrickhlauke
Copy link
Member Author

Also shout if there was a reason for having that "candidate regions" part of the heading that escaped me...but to me that was never really necessary?

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@patrickhlauke
Copy link
Member Author

@smaug---- yup, keep 'em coming. i was naively adding exports to "things that somebody may potentially want to point to from the outside", but i probably overestimated how interesting/relevant they might be from an outside perspective.

Copy link
Contributor

@smaug---- smaug---- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd drop perhaps those few exports

this was also preventing pr-preview from running correctly. with thanks to Denis Ah Kang for spotting the broken link.
@patrickhlauke
Copy link
Member Author

@flackr @mustaqahmed you ok with these changes? i'll merge these end of today unless I hear otherwise if that's ok.

Copy link
Member

@mustaqahmed mustaqahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

index.html Outdated Show resolved Hide resolved
…r and prose to include declare/declaratively
<td>Yes</td>
<td>No</td>
<td>None</td>
</tr>
</tbody>
</table>

<p>Viewport manipulations (panning and zooming) — generally, as a result of a <a>direct manipulation</a> interaction — are intentionally NOT a default action of pointer events, meaning that these behaviors (e.g. panning a page as a result of moving a finger on a touchscreen) cannot be suppressed by canceling a pointer event. Authors must instead use <code>touch-action</code> to explicitly <a href="#declaring-candidate-regions-for-direct-manipulation-behaviors">declare the direct manipulation behavior</a> for a region of the document. Removing this dependency on the cancelation of events facilitates performance optimizations by the user agent.</p>
<p>Viewport manipulations (panning and zooming) — generally, as a result of a <a>direct manipulation</a> interaction — are intentionally NOT a default action of pointer events, meaning that these behaviors (e.g. panning a page as a result of moving a finger on a touchscreen) cannot be suppressed by canceling a pointer event. Authors must instead use <code>touch-action</code> to explicitly <a>declare the direct manipulation behavior</a> for a region of the document. Removing this dependency on the cancelation of events facilitates performance optimizations by the user agent.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nit, sorry: the "the" in "declare the direct manipulation behavior" sounds a bit odd to me because at this point the behavior is not defined to the reader. Perhaps this is only me, but calling our regardless.

@patrickhlauke patrickhlauke merged commit 294fffd into gh-pages Jun 1, 2022
@patrickhlauke patrickhlauke deleted the patrickhlauke-respec-fixes branch June 1, 2022 16:07
@patrickhlauke patrickhlauke mentioned this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up ReSpec errors
3 participants