This repository has been archived by the owner on May 5, 2022. It is now read-only.
Make 'as' attribute mandatory #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <li>The specified <code><a>as</a></code> value MUST be a valid <a href="http://fetch.spec.whatwg.org/#concept-request-context">request context</a> as defined in [[FETCH]].</li> | ||
| <li>If the <code><a>as</a></code> attribute is missing, the user agent MUST assign a default context.</li> | ||
| <li>If the <code><a>as</a></code> attribute is omitted, or the value contains an invalid request context, then the user agent SHOULD output a developer-friendly warning and abort the fetch.</li> |
There was a problem hiding this comment.
Maybe "Must abort the fetch" to avoid various UAs acting differently on such authoring errors?
There was a problem hiding this comment.
We can't enforce a MUST. E.g. there is no way to abort an inflight HTTP/1 request short of sending a TCP RST, which carries a high penalty and requirement to open a new connection... which may or may not make sense, and this should be deferred to the UA.
There was a problem hiding this comment.
Oh, are we talking about an in-flight fetch here?
igrigorik
added a commit
that referenced
this pull request
Apr 1, 2015
Make 'as' attribute mandatory
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2 for background. Closes #2.