Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pushRegistrationId attribute from push event #32

Closed
mvano opened this issue Sep 1, 2014 · 0 comments
Closed

Remove pushRegistrationId attribute from push event #32

mvano opened this issue Sep 1, 2014 · 0 comments

Comments

@mvano
Copy link
Contributor

mvano commented Sep 1, 2014

Currently there's both data and pushRegistrationId on a push event. I see no real use case for the id. Is this a leftover from when the api supported multiple registrations / channels? Let's remove it.

If the author really wants to have the id it can be read from getRegistration and we can always add it back if we find a strong use case.
mvano added a commit to mvano/push-api that referenced this issue Sep 2, 2014
@mvano
Remove pushRegistrationId from PushMessage. Fixes issue w3c#32.
406f36e
efullea pushed a commit that referenced this issue Sep 3, 2014
Merge pull request #34 from mvano/RemoveIdFromPushEvent
1acbfaa 
Remove pushRegistrationId from PushMessage. Fixes issue #32.
@efullea efullea closed this as completed Sep 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@efullea @mvano