Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add several paragraphs and examples to Overview section. #69

Merged
merged 12 commits into from
Dec 20, 2020
Merged

Add several paragraphs and examples to Overview section. #69

merged 12 commits into from
Dec 20, 2020

Conversation

bobdc
Copy link
Contributor

@bobdc bobdc commented Dec 13, 2020

Note that some of the original Overview content has been commented out as opposed to removed. See the comment I added to it.


Preview | Diff

rdf-star-cg-spec.html Outdated Show resolved Hide resolved
rdf-star-cg-spec.html Outdated Show resolved Hide resolved
bobdc and others added 2 commits December 14, 2020 14:04
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
rdf-star-cg-spec.html Outdated Show resolved Hide resolved
Co-authored-by: Pierre-Antoine Champin <github-100614@champin.net>
@pfps
Copy link

pfps commented Dec 17, 2020

The lead example needs to be changed. Dates are not part of the core of RDF. Even if they were, dates in date-aware systems are not strings. An example that uses only the notions are are required to be supported in RDF is needed.

@pfps
Copy link

pfps commented Dec 17, 2020

RDF does not allow subjects or objects of triples to be triples. RDF reification is something different - instances of rdf:Statement have an intended meaning that is some sort of description of an RDF triple. The distinction is subtle but profound and if this document is going to make any claim about RDF reification it needs to a completely correct claim.

rdf-star-cg-spec.html Outdated Show resolved Hide resolved
@pchampin
Copy link
Collaborator

@pfps the running example in the RDF 1.1 Primer uses dates.

An example that uses only the notions are are required to be supported in RDF is needed

Furthermore, the example does not rely on any special understanding or recognizing of the date datatype. It is just a literal; How is it not supported in RDF?

@pfps
Copy link

pfps commented Dec 17, 2020

The example uses dates, as far as I can tell. These are not necessarily supported in RDF and could be considered to be just like "2004-04-03"^^ex:junk in some RDF systems. Either that or the date in the example is just a string, which is worse.
So either use something that is just a string or avoid literals.

rdf-star-cg-spec.html Outdated Show resolved Hide resolved
rdf-star-cg-spec.html Outdated Show resolved Hide resolved
bobdc and others added 3 commits December 17, 2020 13:57
Co-authored-by: Pierre-Antoine Champin <github-100614@champin.net>
Co-authored-by: Pierre-Antoine Champin <github-100614@champin.net>
Co-authored-by: Pierre-Antoine Champin <github-100614@champin.net>
rdf-star-cg-spec.html Outdated Show resolved Hide resolved
bobdc and others added 2 commits December 17, 2020 14:03
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@pchampin
Copy link
Collaborator

This was discussed during today's call: https://w3c.github.io/rdf-star/Minutes/2020-12-18.html#item03

Copy link
Collaborator

@pchampin pchampin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in today's call: it would be better if the example didn't involve the xsd:date, which could give the wrong impression that all RDF* implementations need to recognize that datatype.

rdf-star-cg-spec.html Outdated Show resolved Hide resolved
rdf-star-cg-spec.html Outdated Show resolved Hide resolved
rdf-star-cg-spec.html Outdated Show resolved Hide resolved
bobdc and others added 3 commits December 18, 2020 13:37
Co-authored-by: Pierre-Antoine Champin <github-100614@champin.net>
Co-authored-by: Pierre-Antoine Champin <github-100614@champin.net>
Co-authored-by: Pierre-Antoine Champin <github-100614@champin.net>
@pchampin
Copy link
Collaborator

Thanks @bobdc , good to go :)

@pchampin pchampin merged commit 740deb3 into w3c:main Dec 20, 2020
@bobdc
Copy link
Contributor Author

bobdc commented Dec 20, 2020

Thank you!

@hartig
Copy link
Collaborator

hartig commented Dec 20, 2020

Thanks @bobdc for your efforts!

@bobdc
Copy link
Contributor Author

bobdc commented Dec 20, 2020

I just noticed that we never updated the "After declaring a prefix URI" paragraph to reference the the new familyName and jobTitle triples. Should I fix that in a separate pull request or can someone add that in another update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants