Editorial: Use the HTML spec's timers infrastructure for timeout
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In whatwg/html#7349, the HTML spec factored out part of the infrastructure for `setTimeout()` into a "run steps after a timeout" algorithm for use by other specs. This change updates `requestIdleCallback()` to use that algorithm when the `timeout` property is present and positive.
|
andreubotella marked as non substantive for IPR from ash-nazg. |
|
Come to think about it, this change is not in fact editorial, since the "run steps after a timeout" algorithm adds an entry to the map of active timers, which in turn affects the idle deadline. |
|
@andreubotella - For some reason, we never clicked the green button and merged this.. Any reason I shouldn't? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In whatwg/html#7349, the HTML spec factored out part of the infrastructure for
setTimeout()into a "run steps after a timeout" algorithm for use by other specs. This change updatesrequestIdleCallback()to use that algorithm when thetimeoutproperty is present and positive.Preview | Diff