Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rendering Enveloped Verifiable Presentations #40

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

decentralgabe
Copy link
Collaborator

fix #39

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@decentralgabe decentralgabe merged commit b09a937 into main Aug 7, 2024
1 check passed
@decentralgabe decentralgabe deleted the enveloped-vps branch August 7, 2024 15:06
@decentralgabe
Copy link
Collaborator Author

decentralgabe commented Aug 7, 2024

@msporny will need your help creating a release in NPM, when you get a chance, please.

I created a github release here https://github.com/w3c/respec-vc/releases/tag/3.3.3

@decentralgabe
Copy link
Collaborator Author

so https://cdn.jsdelivr.net/gh/w3c/respec-vc@3.3.2/dist/main.js exists
but https://cdn.jsdelivr.net/gh/w3c/respec-vc@3.3.3/dist/main.js does not

I am not sure how you got the dist folder and artifacts to be present for 3.3.2...

@msporny
Copy link
Member

msporny commented Aug 7, 2024

You have to build and check in the dist folder but ONLY on the tag (it becomes a disconnected branch commit). The way I do this is usually:

  1. Branch off on a release-3.3.3 branch.
  2. Build, add, and commit dist/main.js.
  3. Tag the latest commit and push the tag up to the repo.
  4. Go back to main and delete the release-3.3.3 branch w/o merging it.

If that doesn't make sense, we'll push your changes out when we fix the Echidna stuff. Let me check w/ @BigBlueHat if those changes are ready to go and I'll try to push a release out.

You /might/ be able to update the 3.3.3 tag w/ the dist/main.js checked in, but I have no idea if jsdelivr caches tag releases temporarily/permanently, or checks for hash changes? We might have to mark 3.3.3 as a broken tag release?

@decentralgabe
Copy link
Collaborator Author

thanks @msporny that worked -- https://cdn.jsdelivr.net/gh/w3c/respec-vc@3.3.3/dist/main.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support EnvelopedVerifiablePresentation examples for VC-JOSE-COSE
4 participants