Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deactivating hyperlinking in examples #777

Closed
plehegar opened this issue May 19, 2016 · 7 comments
Closed

Deactivating hyperlinking in examples #777

plehegar opened this issue May 19, 2016 · 7 comments
Labels
bug

Comments

@plehegar
Copy link
Member

Compare
https://www.w3.org/TR/resource-hints/#fetching-the-resource-hint-link
with
https://w3c.github.io/resource-hints/#fetching-the-resource-hint-link

It seems that the new highlighter is attempted to be too smart for its own good.

The hyperlink is https://example.com/next-page.html%3E
and really, we should link to example.com in the first place. Is there a way to disable this?
@plehegar plehegar added the bug label May 19, 2016
@marcoscaceres
Copy link
Member

I'll see how we can turn it off. I think it's the markdown parser (might be doing the right thing, but we should be able to disable it).

@plehegar
Copy link
Member Author

fyi, this blocked the TR update of resource hints yesterday. this would be worth adding into the testbed.

@marcoscaceres
Copy link
Member

@plehegar, this is a "feature" of markdown it seems (https://gist.github.com/alexpeattie/4729247). It can be disabled with a few hacks (e.g., the http:<span></span>//some.url one).

@marcoscaceres
Copy link
Member

A solution might be to add a nolink class. I can then convert HTMLAnchors to text nodes.

@marcoscaceres marcoscaceres mentioned this issue May 20, 2016
Merged
@marcoscaceres
Copy link
Member

PR sent.

@plehegar
Copy link
Member Author

LGTM.

@marcoscaceres
Copy link
Member

Thanks! Something is tripping up one of the tests. Looking into it.

On 21 May 2016, at 2:24 AM, Philippe Le Hegaret notifications@github.com wrote:

LGTM.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub

marcoscaceres pushed a commit that referenced this issue May 21, 2016
Merge pull request #778 from w3c/Bug_777_deactivate_link_in_md
ec91761 
Feat(markdown): disable md linking via 'nolinks' class (closes #777)
marcoscaceres added a commit that referenced this issue May 23, 2016
@marcoscaceres
Merge branch 'develop' into gh-pages
4d9548c 
* develop:
  v3.2.124
  Fix(ui): close ui when doc is clicked (closes #772)
  Fix(base-runner): improve error reporting
  Fix(markdown): use Array.from instead of for/of loop
  Fix(headers-spec): should query doc, not document
  Fix(markdown-spec): should query doc, not document
  Feat(markdown): disable md linking via 'nolinks' class (closes #777)
  Chore(travis): Bump node version to 6.2
  Chore(appveyor): Bump node version to 6.2
  Feat(save-html): beautify HTML/XML output (closes #750)
  Feat(hightlight): use new highlighter (#767)
  Fix(SpecHelper): remove isPhantom() dead code
  Feat(utils): map/reduce linkCSS() instead of jQuery
  Fix (SpecHelper): reduce dependece on jQuery
  Fix(style): reduce ReSpec FOUC (relates to #326)
  Feat(utils): add makeOwnerSwapper() (#766)
  Fix(beautify-options): disable wrap_line_length, as it gets confused
shikhar-scs pushed a commit to shikhar-scs/respec that referenced this issue Feb 19, 2018
@thomaschampagne @wlach
Add mouse over events on Marker text (w3c#777)
37ddb05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcoscaceres @plehegar