Feat(hightlight): use new highlighter #767
Conversation
|
Review please 🍨 |
marcoscaceres
force-pushed
the
highlightjs
branch
from
937d8ea
to
28545b5
Compare
|
rebased. |
marcoscaceres
force-pushed
the
highlightjs
branch
2 times, most recently
from
61f8cfe
to
43e4a22
Compare
|
highlighting now happens after linking, so not to affect linking. |
marcoscaceres
force-pushed
the
highlightjs
branch
from
43e4a22
to
183cd50
Compare
|
This seems fine. I am concerned, as usual, about backward compatibility. In this case the change of requiring nohighlight means documents that formerly would NOT have had highlighting on some examples will now suddenly have it. This may come as a surprise to their editors. |
🦄☄✨I like to imagine them being delighted by whimsy✨☄🦄 But that's a good point. I'll email spec-prod.
|
|
Email sent! |
* 'develop' of github.com:w3c/respec: Feat(hightlight): use new highlighter (#767)
* develop: v3.2.124 Fix(ui): close ui when doc is clicked (closes #772) Fix(base-runner): improve error reporting Fix(markdown): use Array.from instead of for/of loop Fix(headers-spec): should query doc, not document Fix(markdown-spec): should query doc, not document Feat(markdown): disable md linking via 'nolinks' class (closes #777) Chore(travis): Bump node version to 6.2 Chore(appveyor): Bump node version to 6.2 Feat(save-html): beautify HTML/XML output (closes #750) Feat(hightlight): use new highlighter (#767) Fix(SpecHelper): remove isPhantom() dead code Feat(utils): map/reduce linkCSS() instead of jQuery Fix (SpecHelper): reduce dependece on jQuery Fix(style): reduce ReSpec FOUC (relates to #326) Feat(utils): add makeOwnerSwapper() (#766) Fix(beautify-options): disable wrap_line_length, as it gets confused
|
is there a way to overwrite / bypass the new highlighting? (I also commented here). We have special css formatting for different |
|
@jimkont I tried with setting "noHighlightCSS", seems to work well for your case: http://w3c.github.io/data-shapes/shacl/?noHighlightCSS=true |
see w3c/respec#767 for details
|
works perfect! thanks @marcoscaceres |
depends on #766, so won't pass until that one is merged.
I've simplified highlighting a bit more. As we have been warning people about deprecated classes since 2013, I've removed that warning code related to "sh_css sh_html sh_javascript sh_javascript_dom sh_xml". Highlighting now happens by default, instead of requiring eds. to put "highlight" everywhere.
Disabling highlight can be done with "nohighlight".