Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(utils): add makeOwnerSwapper() #766

Merged
merged 1 commit into from May 18, 2016
Merged

Feat(utils): add makeOwnerSwapper() #766

merged 1 commit into from May 18, 2016

Conversation

marcoscaceres
Copy link
Member

Utility function that allows swapping a Node from one document to another. Useful for various incoming improvements.

@marcoscaceres
Copy link
Member Author

r please?

This was referenced May 17, 2016
Merged
Merged
@marcoscaceres
Copy link
Member Author

Merging, as it's causing me bit-rot and can't proceed without it. Would still appreciate a once over.

@marcoscaceres marcoscaceres merged commit f06ceba into develop May 18, 2016
@marcoscaceres marcoscaceres deleted the owner_swapper branch May 18, 2016 05:46
@halindrome
Copy link
Contributor

Sorry, I have been heads down parenting for a week or so. Question: do you know the level of support for adoptNode. I had not seen it before, and the DOM Recommendation has text about what to do if it is not supported (which, I suppose, we could just do. It seems simple enough).

@marcoscaceres
Copy link
Member Author

On 18 May 2016, at 10:45 PM, Shane McCarron notifications@github.com wrote:

Sorry, I have been heads down parenting for a week or so. Question: do you know the level of support for adoptNode.

It's a pretty ancient API (like late 1990s), so will be well supported. At least, not had any problems in the browsers on my machine. It's been in Firefox since version 3.

I had not seen it before, and the DOM Recommendation has text about what to do if it is not supported (which, I suppose, we could just do. It seems simple enough).

The importNode() stuff? It's probably not needed, tbh. At least, I haven't had any issues as the sub documents we create are all spawned from the same document.

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub

@halindrome
Copy link
Contributor

Excellent. Thanks

marcoscaceres added a commit that referenced this pull request May 23, 2016
@marcoscaceres
Merge branch 'develop' into gh-pages
4d9548c 
* develop:
  v3.2.124
  Fix(ui): close ui when doc is clicked (closes #772)
  Fix(base-runner): improve error reporting
  Fix(markdown): use Array.from instead of for/of loop
  Fix(headers-spec): should query doc, not document
  Fix(markdown-spec): should query doc, not document
  Feat(markdown): disable md linking via 'nolinks' class (closes #777)
  Chore(travis): Bump node version to 6.2
  Chore(appveyor): Bump node version to 6.2
  Feat(save-html): beautify HTML/XML output (closes #750)
  Feat(hightlight): use new highlighter (#767)
  Fix(SpecHelper): remove isPhantom() dead code
  Feat(utils): map/reduce linkCSS() instead of jQuery
  Fix (SpecHelper): reduce dependece on jQuery
  Fix(style): reduce ReSpec FOUC (relates to #326)
  Feat(utils): add makeOwnerSwapper() (#766)
  Fix(beautify-options): disable wrap_line_length, as it gets confused
@saschanaz saschanaz mentioned this pull request Dec 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcoscaceres @halindrome