Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sosa:Host retain sosa:Platform #99

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Conversation

dr-shorthair
Copy link
Collaborator

Added note to explain that sosa:Platform is the SOSA implementation of OMS Host.

Closes #56

Added note to explain that `sosa:Platform` is the SOSA implementation of OMS Host.
Copy link
Contributor

@rob-metalinkage rob-metalinkage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this reflects the discussion and moves us forward to a review step.

@rob-metalinkage
Copy link
Contributor

I did ask to see if @alexrobin could be added to the repository and review candidates.

Copy link
Contributor

@sgrellet sgrellet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on ssn/integrated/sosa.ttl

line 202 "An environmental monitoring facility.". I wonder if that would make sense to refer to EU INSPIRE directive (2007/2/EC) theme 'Environmental Monitoring Facilities' (INSPIRE:EF) or create more confusion.
Indeed, the OMS:Host is modelled having in mind the work we did on INSPIRE:EF with @kathi (and we should convince JRC to update that dataspecs)

line 338 sosa:Observer a rdfs:Class , owl:Class ;
will we discuss the sosa:Sensor VS OMS:Observer in another issue and PR ?

@alexrobin
Copy link
Collaborator

Thanks Simon. Looks good to me

@dr-shorthair
Copy link
Collaborator Author

@sgrellet asked

line 338 sosa:Observer a rdfs:Class , owl:Class ;
will we discuss the sosa:Sensor VS OMS:Observer in another issue and PR ?

See #100

@dr-shorthair
Copy link
Collaborator Author

@sgrellet asked

line 202 "An environmental monitoring facility.". I wonder if that would make sense to refer to EU INSPIRE directive (2007/2/EC) theme 'Environmental Monitoring Facilities' (INSPIRE:EF) or create more confusion.

If sosa:Platform is functionally equivalent to EMF then that could be mentioned in the documentation or annotation. Perhaps this could be added as a dcterms:source reference?

For the time being I have added a skos:scopeNote.

Also see #57 for some ideas about how to document alignment to OMS.

Copy link
Contributor

@sgrellet sgrellet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If sosa:Platform is functionally equivalent to EMF then that could be mentioned in the documentation or annotation. Perhaps this could be added as a dcterms:source reference?

I'll add this as a dcterms:source. This will help using SOSA while maintaining compliancy with EU specs

@dr-shorthair dr-shorthair merged commit d5430d0 into gh-pages Oct 3, 2023
@dr-shorthair dr-shorthair deleted the platform-vs-host branch October 7, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants