Update of OWL-Time ontology, extended with rdfs:label, rdfs:comment a… #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd skos:definition in Spanish for each definition where they were formerly just in English.
…version of time English will be easier to be identified
dr-shorthair
requested changes
Feb 4, 2018
There was a problem hiding this comment.
That’s helpful.
I found an additional stray assertion:
:intervalEquals owl:propertyDisjointWith :intervalIn .
This may be correct, but is a semantic modification to what was agreed so can’t be slipped through in this way.
Also: \n\n linefeeds inside strings are not reliably valid RDF. Turtle supports multi-line text inside triple quotes.
Finally – the rdfs:Description type assertions are redundant in the .ttl and .nt versions at least.
I can see how they might have sneaked in because of moving the translations to a separate block, but they can be removed from the .ttl and .nt versions at least.
…tervalIn that was repeated in the Spanish section
dr-shorthair
approved these changes
Feb 20, 2018
|
Thanks a lot!
Mariano
2018-02-20 8:22 GMT+01:00 Simon Cox <notifications@github.com>:
… Merged #1002 <#1002>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1002 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AHng2d1_pXo_0SWzgBUv9DxzBWQ_lLonks5tWnK9gaJpZM4Rjir5>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd skos:definition in Spanish for each definition where they were formerly just in English.