[QB4ST] Outline was borked because of missing closing tags #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated ReSpec config to display the right logos and use HTTPS links as now required by publication rules.
BillSwirrl
approved these changes
Apr 13, 2017
|
Thanks, not sure what process the group uses for merging pull requests, but I suppose @rob-metalinkage is the one responsible for that one, as editor of the spec. |
ReSpec takes care of the viewport declaration and the one that was in the spec is no longer pubrules compliant.
|
Note I added a couple more fixes done as I was checking publication rules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, the outline was wrong starting with the "Requirements" section, and the first appendix appeared as a subsection of last section.
I also updated ReSpec config to display the right logos and use HTTPS links as now required by publication rules.