The Sensor.lastEventFiredAt internal slot is useless #199
Assignees
Milestone
Comments
This was referenced May 19, 2017
pozdnyakov
pushed a commit
to pozdnyakov/sensors
that referenced
this issue
May 23, 2017
…d internal slots used in the Sensor interface specification.
The refactoring goals are:
Recompose abstract operations so that duplication of the algorithms steps is removed.
Drop the unused abstract operations and internal slots.
Also the change brings the following behavioral changes:
Fixes w3c#152. Each Sensor instance reads the sensor readings considering its individual
frequency hint, sends 'onchange' and caches the sensor latest reading at this moment.
The Sensor's attributes return values from the cached reading.
Thus we achieve:
appearance of a new Sensor instance with a higher frequency hint does not affect the behavior of the existing Sensor instances of the same type.
consistency between the Sensor's 'onchange' notification and its attribute values.
Fixes w3c#168. A Sensor object returns reading values only in "activated" state and returns null otherwise.
Fixes w3c#199
Fixes w3c#200
Fixes w3c#201
Fixes w3c#203
pozdnyakov
pushed a commit
to pozdnyakov/sensors
that referenced
this issue
Jun 28, 2017
…d internal slots used in the Sensor interface specification.
The refactoring goals are:
Recompose abstract operations so that duplication of the algorithms steps is removed.
Drop the unused abstract operations and internal slots.
Also the change brings the following behavioral changes:
Fixes w3c#152. Each Sensor instance reads the sensor readings considering its individual
frequency hint, sends 'onchange' and caches the sensor latest reading at this moment.
The Sensor's attributes return values from the cached reading.
Thus we achieve:
appearance of a new Sensor instance with a higher frequency hint does not affect the behavior of the existing Sensor instances of the same type.
consistency between the Sensor's 'onchange' notification and its attribute values.
Fixes w3c#168. A Sensor object returns reading values only in "activated" state and returns null otherwise.
Fixes w3c#199
Fixes w3c#200
Fixes w3c#201
Fixes w3c#203
pozdnyakov
pushed a commit
to pozdnyakov/sensors
that referenced
this issue
Jun 30, 2017
…d internal slots used in the Sensor interface specification. The refactoring goals are: 1) Stop firing events synchronously. 2) Clean up the internal slots after stop or error. 3) Fix logical errors in the abstract operations. 3) Recompose abstract operations so that duplication of the algorithms steps is removed. 4) Drop the unused abstract operations and internal slots. Fixes w3c#199 Fixes w3c#200 Fixes w3c#201 Fixes w3c#203 Fixes w3c#218 Fixes w3c#215 Fixes w3c#204
|
Fixed with #210 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
Sensor.lastEventFiredAtinternal slot only gets assigned in https://w3c.github.io/sensors/#update-observers but not used anywhere else.The text was updated successfully, but these errors were encountered: