Queue tasks for [[state]] changes. #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
pozdnyakov
approved these changes
May 31, 2017
| @@ -907,7 +908,7 @@ The getter of the {{Sensor/timestamp!!attribute}} attribute returns | |||
| The {{Sensor/stop()}} method must run these steps: | |||
|
|
|||
| 1. If |sensor_instance|.{{[[state]]}} is "idle", then return. | |||
| 1. Set |sensor_instance|.{{[[state]]}} to "idle". | |||
| 1. [=Queue a task=] to set |sensor_instance|.{{[[state]]}} to "idle". | |||
There was a problem hiding this comment.
Similar to start(), looks like invocations would queue multiple state change tasks + invoke unregister sensor object multiple times, right?
| 1. Set |sensor_instance|.{{[[state]]}} to "activating". | ||
| 1. If |sensor_state| is either "activating" or "activated", | ||
| then return. | ||
| 1. [=Queue a task=] to set |sensor_instance|.{{[[state]]}} to "activating". |
There was a problem hiding this comment.
The state is not yet 'activating', thus, consecutive start() invocations will queue multiple state change tasks + invoke register sensor multiple times. @pozdnyakov?
There was a problem hiding this comment.
Yeah, you're right. That doesn't work.
| 1. Set |sensor_instance|.{{[[state]]}} to "idle". | ||
| 1. [=Fire an event=] named "error" at |sensor_instance| using {{SensorErrorEvent}} | ||
| with its {{SensorErrorEvent/error!!attribute}} attribute initialized to |error|. | ||
| 1. [=Queue a task=] to run these steps: |
There was a problem hiding this comment.
What about 'unregister' and resetting internal slots? Do we have issue for that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #218.
Preview | Diff