Introduce Default Sensor concept #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This solves an inline issue. PTAL. |
index.bs
Outdated
| <pre highlight="js"> | ||
| let sensor = new GeolocationSensor({ accuracy: "high" }); | ||
|
|
||
| sensor.onreading = function(event) { |
index.bs
Outdated
| while still enabling more complex use cases. | ||
|
|
||
| Most of devices deployed today do not carry more than one | ||
| [=device sensor=] corresponding to the same [=sensor type|sensor types=]. |
index.bs
Outdated
| [=device sensor=] corresponding to the same [=sensor type|sensor types=]. | ||
| The use cases which require a set of similar [=device sensors=] are rare | ||
| and generally limited to specific [=sensor types=], | ||
| such as proximity sensors. |
There was a problem hiding this comment.
not really, accelerometers are better example, especially for 2-in-1 or convertible devices. Maybe change proximity to accelerometer?
index.bs
Outdated
| the <dfn export>default sensor</dfn> is chosen. | ||
|
|
||
| <div class="example"> | ||
| Listening to geolocation changes: |
There was a problem hiding this comment.
Would be nice to use sensors that are actually specified, implemented.
index.bs
Outdated
| Note: extension to this specification may choose not to define a default sensor | ||
| when doing so wouldn't make sense. | ||
| For example, it might be difficult to agree on an obvious default [=device sensor|sensor=] for | ||
| proximity [=device sensor|sensors=]. |
There was a problem hiding this comment.
I would change proximity to geolocation.
pozdnyakov
force-pushed
the
Introduce_default_sensor_concept
branch
from
396b6c2
to
e0e88e7
Compare
|
@alexshalamov ptal |
|
@anssiko could you PTAL? |
|
pr-preview did not work for some reason, so here's the HTML diff: |
anssiko
approved these changes
Sep 25, 2017
Closed
- Move the dedicated text from the 'Background' to the 'Concepts' section - Cleanup
pozdnyakov
force-pushed
the
Introduce_default_sensor_concept
branch
from
e0e88e7
to
b918749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff