Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial fixes to Extensibility section #291

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Editorial fixes to Extensibility section #291

merged 1 commit into from
Sep 27, 2017

Conversation

anssiko
Copy link
Member

@anssiko anssiko commented Sep 27, 2017 •
edited by pr-preview bot
Loading

alexshalamov
alexshalamov approved these changes Sep 27, 2017
View reviewed changes
Copy link

@alexshalamov alexshalamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, small nit for text unrelated to this PR.

index.bs

<dfn lt="extension specification">Extension specifications</dfn> are encouraged to focus on a
Such <dfn lt="extension specification">extension specifications</dfn> are encouraged to focus on a
single [=sensor type=], exposing both [=high-level|high=] and [=low-level|low=] level
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed:

single [=sensor type=], exposing both [=high-level|high=] and [=low-level|low=] level as appropriate.

Should and be replaced with or? Now, it sounds like extension for single type should expose both, high and low.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ”as appropriate” makes this ”and/or” in practice. Would keep as is.

@anssiko
Copy link
Member Author

anssiko commented Sep 27, 2017

Thanks for the review!

@anssiko anssiko merged commit eb89a4c into master Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwaldron rwaldron rwaldron approved these changes

@alexshalamov alexshalamov alexshalamov approved these changes

@pozdnyakov pozdnyakov Awaiting requested review from pozdnyakov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anssiko @rwaldron @alexshalamov