Introduce the Reading Timestamp concept #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anssiko
requested changes
Sep 29, 2017
index.bs
Outdated
| at which the [=latest reading=] was obtained | ||
| expressed in milliseconds that passed since the [=time origin=]. | ||
| The [=latest reading=] [=ordered map|map=] contains an [=map/entry=] whose [=map/key=] is | ||
| "timestamp" and whose [=map/value=] is a high resolution timestamp estimating the |
There was a problem hiding this comment.
s/estimating the/that represents the estimate of the/
index.bs
Outdated
| "timestamp" and whose [=map/value=] is a high resolution timestamp estimating the | ||
| [=reading timestamp=] expressed in milliseconds that passed since the [=time origin=]. | ||
|
|
||
| Note: The accuracy of the [=reading timestamp=] estimation depends on the underlying |
|
LGTM % some editing suggestions |
markafoltz
reviewed
Sep 29, 2017
index.bs
Outdated
| @@ -473,7 +473,7 @@ which are a source of information about the user and their environment. | |||
|
|
|||
| Each [=raw sensor reading|reading=] is composed of the <dfn lt="reading value">values</dfn> | |||
| of the different physical quantities measured by the [=device sensor|sensor=] | |||
| at time <var ignore>t<sub>n</sub></var>. | |||
| at time <var ignore>t<sub>n</sub></var> which is called <dfn>reading timestamp</dfn>. | |||
index.bs
Outdated
| at which the [=latest reading=] was obtained | ||
| expressed in milliseconds that passed since the [=time origin=]. | ||
| The [=latest reading=] [=ordered map|map=] contains an [=map/entry=] whose [=map/key=] is | ||
| "timestamp" and whose [=map/value=] is a high resolution timestamp estimating the |
index.bs
Outdated
| expressed in milliseconds that passed since the [=time origin=]. | ||
| The [=latest reading=] [=ordered map|map=] contains an [=map/entry=] whose [=map/key=] is | ||
| "timestamp" and whose [=map/value=] is a high resolution timestamp estimating the | ||
| [=reading timestamp=] expressed in milliseconds that passed since the [=time origin=]. |
|
@mfoltzgoogle @anssiko the latest patch has the review comments addressed. Thanks for taking a look! |
|
LGTM. |
anssiko
approved these changes
Oct 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
Preview | Diff