Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various updates to requirements doc #732

Merged
merged 9 commits into from
Apr 2, 2024
Merged

Various updates to requirements doc #732

merged 9 commits into from
Apr 2, 2024

Conversation

WilcoFiers
Copy link
Contributor

@WilcoFiers WilcoFiers commented Feb 13, 2024

This PR was set up to try and address the various comments from #41

Closes #41

@alastc alastc mentioned this pull request Feb 13, 2024
requirements/index.html Outdated Show resolved Hide resolved
requirements/index.html Outdated Show resolved Hide resolved
requirements/index.html Outdated Show resolved Hide resolved
requirements/index.html Outdated Show resolved Hide resolved
requirements/index.html Outdated Show resolved Hide resolved
@alastc
Copy link
Contributor

alastc commented Feb 20, 2024

Hi @WilcoFiers,

In the meeting we made some suggestions, if you're happy with those we can move it to AG review. If not, we'll catch up next time you can attend.

Copy link
Contributor

@jspellman jspellman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 116 says "in addition pass/fail statements" but should say "true/false statements". Ultimately, everything will resolve to pass fail, so that is not sufficiently accurate.

requirements/index.html Outdated Show resolved Hide resolved
@alastc alastc dismissed jspellman’s stale review April 2, 2024 10:30

Change adopted.

@alastc alastc merged commit 570db02 into main Apr 2, 2024
4 of 5 checks passed
@alastc alastc deleted the wcag3-req-wilco branch April 2, 2024 10:31
github-actions bot added a commit that referenced this pull request Apr 2, 2024
SHA: 570db02
Reason: push, by alastc

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 2, 2024
SHA: 570db02
Reason: push, by alastc

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 2, 2024
SHA: 570db02
Reason: push, by alastc

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 2, 2024
SHA: 570db02
Reason: push, by alastc

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirements feedback
4 participants