Expand checks run by Web IDL study tool #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This expands the Web IDL study tool to run additional checks: - Report unknown types - Report unknown extended attributes - Includes statements: target needs to be of type "interface" - Includes statements: mixin source (includes) needs to exist - Includes statements: type of mixin source needs to be "interface mixin" - Inheritance: same type required These checks match (or should match :)) those performed in Webref already. Reported anomaly objects could be further improved, e.g. to provide a more complete reference to the problematic IDL when it is at the attribute or parameter level and not at the definition level. To be done over time when we start submitting actual anomaly reports! This would for example be useful in the case where an interface definition "Foo" defines 5 `bool` attributes (instead of `boolean`). The tool will currently report 5 anomalies, all saying that the interface "Foo" references unknown type `bool`. Still missing: - Split unknown types into unknown and "known unknown" types, e.g. when an interface references a namespace - Checks once IDL gets merged: overloaded and duplicate methods
More accurately, right now, the tool thinks that it is correct to reference a namespace or a mixin whereas it is not. |
dontcallmedom
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the Web IDL study tool to run additional checks:
These checks match (or should match :)) those performed in Webref already.
Reported anomaly objects could be further improved, e.g. to provide a more complete reference to the problematic IDL when it is at the attribute or parameter level and not at the definition level. To be done over time when we start submitting actual anomaly reports!
This would for example be useful in the case where an interface definition "Foo" defines 5
boolattributes (instead ofboolean). The tool will currently report 5 anomalies, all saying that the interface "Foo" references unknown typebool.Still missing: