File pull requests describing issues found by strudy #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following change in w3c/reffy#1055 Also split code between CLI and re-usable library
tidoust
reviewed
Sep 6, 2022
dontcallmedom
commented
Sep 6, 2022
dontcallmedom
commented
Sep 6, 2022
tidoust
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this builds on #76)
As discussed separately, this creates a mechanism by which we can review potential issues before they get filed on the target repos.
More specifically, this creates a file per type of issue (only broken links at the moment) and spec in an
issues/directory, and submit these individually as pull requests to this repo, if no matching pull request (based on a branch naming convention) or matching issue report exists.Complementary scripts would use the PR merge as a signal to file issues, and would monitor the said issues to remove the report from the repo.
I've tested in my fork of the repo if you want to take a look at what the resulting PR looks like (although the diff isn't very usable there due to the set up of my tests), e.g. dontcallmedom#11